Skip to content

Move floating bar toggle to dedicated tab, fix bar sizing#5816

Merged
kodjima33 merged 3 commits intomainfrom
floating-bar-settings-cleanup
Mar 19, 2026
Merged

Move floating bar toggle to dedicated tab, fix bar sizing#5816
kodjima33 merged 3 commits intomainfrom
floating-bar-settings-cleanup

Conversation

@kodjima33
Copy link
Copy Markdown
Collaborator

Summary

  • Move "Ask omi" toggle from General settings into the Floating Bar tab, renamed to "Show floating bar" (no subtext)
  • Make collapsed floating bar pill slightly taller (4px → 6px) for better visibility
  • Reduce notification width from 430px (AI chat width) to 300px to prevent the bar from becoming excessively wide when notifications appear

Test plan

  • Build compiles successfully
  • Verify "Show floating bar" toggle appears in Settings > Floating Bar
  • Verify toggle is no longer in General settings
  • Verify collapsed bar pill is visible and slightly taller
  • Verify notifications don't stretch the bar to full chat width

🤖 Generated with Claude Code

kodjima33 and others added 3 commits March 19, 2026 01:23
Move the "Ask omi" toggle from General settings into the Floating Bar
tab, rename it to "Show floating bar", and remove the subtext.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Increase the collapsed pill from 4px to 6px height with slightly
rounder corners for better visibility and easier hover targeting.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use a dedicated 300px notification width instead of the 430px AI chat
width to prevent the floating bar from becoming excessively wide when
notifications appear. Also increase collapsed window size from 10px to
14px to match the taller pill.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@kodjima33 kodjima33 merged commit 168e27f into main Mar 19, 2026
2 checks passed
@kodjima33 kodjima33 deleted the floating-bar-settings-cleanup branch March 19, 2026 05:24
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 19, 2026

Greptile Summary

This PR makes three focused UI improvements to the macOS floating control bar: moves the "Show floating bar" toggle from General settings into the dedicated Floating Bar tab, increases the collapsed pill height for better visibility, and narrows the notification overlay to 300 px instead of the full AI-chat width (430 px).

  • Settings reorganisation (SettingsPage.swift): The settingsCard for the toggle is removed from the general section and re-inserted at the top of floatingBarSection, with its settingId correctly updated from "general.askomi" to "floatingbar.show". The toggle logic (FloatingControlBarManager.shared.show/hide) is unchanged.
  • Pill sizing (FloatingControlBarView.swift): The collapsed compactCircleView grows from 4 × 28 px to 6 × 28 px, with corner radius bumped from 2 to 3 to keep the fully-rounded pill appearance.
  • Window sizing (FloatingControlBarWindow.swift): defaultSize / minBarSize heights increase from 10 to 14 px to match the taller pill, and a new notificationWidth = 300 constant is used for the notification overlay resize instead of re-using expandedWidth (430 px). This prevents notifications from stretching the bar to the full AI-chat width.

Confidence Score: 5/5

  • This PR is safe to merge — changes are purely cosmetic and UX-organisational with no functional regressions.
  • All three changes are narrow and well-scoped: a toggle relocation (same logic, new settingId), two numeric constant tweaks (pill height + window min height), and a new width constant for notifications. There are no shared state mutations, no new async flows, and the toggle's show/hide logic is preserved verbatim. No previously working functionality is removed or broken.
  • No files require special attention.

Important Files Changed

Filename Overview
desktop/Desktop/Sources/FloatingControlBar/FloatingControlBarView.swift Compact pill height increased 4→6px and corner radius 2→3px; proportional and consistent with the window min-height bump in FloatingControlBarWindow.swift.
desktop/Desktop/Sources/FloatingControlBar/FloatingControlBarWindow.swift Min/default window height updated 10→14px to match the taller pill, and a dedicated notificationWidth (300px) constant introduced so notifications no longer inherit the full AI-chat width (430px).
desktop/Desktop/Sources/MainWindow/Pages/SettingsPage.swift "Ask omi" toggle removed from General section and re-added (as "Show floating bar", no subtext) at the top of the Floating Bar tab's floatingBarSection. settingId correctly updated from "general.askomi" to "floatingbar.show".

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Floating bar state] --> B{showingAIConversation?}
    B -- Yes --> C[Resize to expandedWidth=430px\nfull AI chat view]
    B -- No --> D{currentNotification != nil?}
    D -- Yes --> E[Resize to notificationWidth=300px\nheight = expandedBarSize + spacing + notificationHeight]
    D -- No --> F{isHovering?}
    F -- Yes --> G[Expand to expandedBarSize\n210 × 50 px]
    F -- No --> H[Collapse to minBarSize\n40 × 14 px\nshows 28 × 6 px pill]
Loading

Last reviewed commit: "Reduce notification ..."

Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
…are#5816)

## Summary
- Move "Ask omi" toggle from General settings into the Floating Bar tab,
renamed to "Show floating bar" (no subtext)
- Make collapsed floating bar pill slightly taller (4px → 6px) for
better visibility
- Reduce notification width from 430px (AI chat width) to 300px to
prevent the bar from becoming excessively wide when notifications appear

## Test plan
- [x] Build compiles successfully
- [ ] Verify "Show floating bar" toggle appears in Settings > Floating
Bar
- [ ] Verify toggle is no longer in General settings
- [ ] Verify collapsed bar pill is visible and slightly taller
- [ ] Verify notifications don't stretch the bar to full chat width

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant