fix: Codemagic bash compat — replace @Q syntax#5823
Merged
Conversation
Codemagic shell does not support ${VAR@Q} parameter transformation.
Use double-quoting for the JS string instead.
Closes #5822
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Greptile SummaryThis PR fixes a one-line shell incompatibility in
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant CM as Codemagic CI
participant GH as GitHub Releases
participant GCS as GCS Bucket
participant Browser as End User Browser
CM->>CM: Build & sign macOS DMG
CM->>GH: Upload omi.dmg as release asset
CM->>CM: Construct BETA_DMG_URL<br/>(github.com/…/omi.dmg)
CM->>CM: Generate /tmp/macos-beta-index.html<br/>with "window.location.replace("${BETA_DMG_URL}")"
CM->>GCS: Upload index.html → beta/index.html
Browser->>GCS: GET beta/index.html
GCS-->>Browser: HTML with JS redirect
Browser->>GH: Redirect → download omi.dmg
Last reviewed commit: "fix: replace Bash 4...." |
Collaborator
Author
|
lgtm |
Glucksberg
pushed a commit
to Glucksberg/omi-local
that referenced
this pull request
Apr 28, 2026
BasedHardware#5823) Codemagic shell does not support ${VAR@Q} parameter transformation. Use double-quoting for the JS string instead. Closes BasedHardware#5822 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
${BETA_DMG_URL@Q}(Bash 4.4+ parameter transformation) with"${BETA_DMG_URL}"in the Codemagic post-build redirect page script. Codemagic's shell doesn't support@Q, causing "bad substitution" that kills the script before prod Cloud Run deploy runs.v0.11.140 and v0.11.141 both failed on this. Once merged, the next tag will trigger a clean Codemagic build that completes prod deploy.
Closes #5822
by AI for @beastoin