fix: remove duplicate 'Unlimited' suffix from plan names

[mdmohsin7]

Summary

• Commit 2db36d8 (Mar 14 — "Add desktop Plan and Usage subscriptions") changed the backend to return full plan titles like "Unlimited Plan Monthly" / "Unlimited Plan Annual" instead of just "Monthly" / "Annual"
• The app-side code in _buildDynamicPlanOption() was still appending " Unlimited", resulting in "Unlimited Plan Monthly Unlimited" and "Unlimited Plan Annual Unlimited"
• Removed the redundant suffix so plan names display correctly

Test plan

• Open the plans sheet and verify plan names no longer show duplicate "Unlimited" text

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

This PR fixes a UI display bug where plan names showed a duplicate "Unlimited" suffix (e.g. "Unlimited Plan Monthly Unlimited") in the plans sheet. The root cause was a mismatch between the backend and frontend: commit 2db36d8a updated backend/routers/payment.py to return complete plan titles ("Unlimited Plan Monthly" / "Unlimited Plan Annual") from the /v1/payments/available-plans endpoint, but the Flutter widget _buildDynamicPlanOption() in plans_sheet.dart was still appending " Unlimited" to whatever title came from the API.

Key changes:

• Replaced final title = '${planData['title']} Unlimited'; with final title = planData['title'] as String; — a minimal, targeted fix that correctly surfaces the backend-provided title for all plan types (including "Omi Pro Monthly" / "Omi Pro Annual").
• No logic, layout, or state management changes are included.

The fix is straightforward and correctly aligns the frontend with the updated backend contract.

Confidence Score: 5/5

• This PR is safe to merge — the single-line change simply removes a stale string concatenation that was producing malformed plan titles.
• The change is a one-line fix with no risk of regressions: it removes an incorrect string interpolation and directly uses the server-provided title, which is already the complete, intended display string. The backend and Flutter API client have been verified to agree on the title format ("Unlimited Plan Monthly", "Unlimited Plan Annual", etc.).
• No files require special attention.

Important Files Changed

Filename	Overview
app/lib/pages/settings/widgets/plans_sheet.dart	Single-line fix removes redundant " Unlimited" suffix concatenation in _buildDynamicPlanOption() — the backend already returns full plan titles like "Unlimited Plan Monthly", so the old interpolation was producing "Unlimited Plan Monthly Unlimited". The fix casts planData['title'] directly as a String, which is correct.

Sequence Diagram

sequenceDiagram
    participant App as Flutter App
    participant API as Backend /v1/payments/available-plans
    participant Stripe as Stripe API

    App->>API: GET /v1/payments/available-plans
    API->>Stripe: Retrieve monthly price
    Stripe-->>API: price_data (unit_amount, interval)
    API->>Stripe: Retrieve annual price
    Stripe-->>API: price_data (unit_amount, interval)
    API-->>App: { plans: [ { title: "Unlimited Plan Monthly", ... }, { title: "Unlimited Plan Annual", ... } ] }
    Note over App: Before fix: title = planData['title'] + " Unlimited"<br/>→ "Unlimited Plan Monthly Unlimited" ❌
    Note over App: After fix: title = planData['title'] as String<br/>→ "Unlimited Plan Monthly" ✅
    App->>App: _buildDynamicPlanOption(planData)
    App->>App: _buildHardcodedPlanOption(title: title, ...)

Loading

_{Last reviewed commit: "fix: remove duplicat..."}