Skip to content

Revert hotfix: remove Deepgram/Gemini keys from config endpoint#5879

Merged
beastoin merged 1 commit intomainfrom
revert/hotfix-config-keys
Mar 21, 2026
Merged

Revert hotfix: remove Deepgram/Gemini keys from config endpoint#5879
beastoin merged 1 commit intomainfrom
revert/hotfix-config-keys

Conversation

@beastoin
Copy link
Copy Markdown
Collaborator

Summary

  • Reverts commit c720b65 which was incorrectly pushed directly to main
  • Removes deepgram_api_key and gemini_api_key from /v1/config/api-keys response
  • v0.11.147 clients use /v1/proxy/* endpoints instead — old clients will auto-update via Sparkle

Why

The hotfix was unnecessary. v0.11.147 (with proxy support) is building via Codemagic and will auto-update all users via Sparkle. No need to maintain backward compat for v0.11.146.

🤖 Generated with Claude Code

by AI for @beastoin

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 21, 2026

Greptile Summary

This PR reverts commit c720b65, removing deepgram_api_key and gemini_api_key from the /v1/config/api-keys response now that v0.11.147 proxies those services server-side through /v1/proxy/deepgram/* and /v1/proxy/gemini/*. The change is minimal, well-documented, and improves security by keeping those keys off the wire.

  • Removes deepgram_api_key and gemini_api_key from ApiKeysResponse struct and handler in config.rs
  • Updates file-level and function-level comments to accurately describe the new architecture
  • AppState.config retains those keys for use by the proxy routes — only the config endpoint response is affected
  • Backward compatibility for v0.11.146 clients is addressed by Sparkle auto-update to v0.11.147; no code changes needed here

Confidence Score: 5/5

  • This PR is safe to merge — it is a clean, minimal revert with no logic errors or security regressions.
  • The change touches a single file, removes two struct fields and their corresponding handler assignments, and updates comments. The proxy routes that still need the Deepgram/Gemini keys operate directly on AppState.config, so those keys remain available server-side. The only migration concern (older clients losing their keys) is intentionally addressed by the Sparkle auto-update path described in the PR.
  • No files require special attention.

Important Files Changed

Filename Overview
desktop/Backend-Rust/src/routes/config.rs Removes deepgram_api_key and gemini_api_key fields from ApiKeysResponse struct and the handler; updates comments to reflect that these keys are now proxied server-side via /v1/proxy/* routes.

Sequence Diagram

sequenceDiagram
    participant C146 as Client v0.11.146 (old)
    participant C147 as Client v0.11.147+
    participant API as Backend API
    participant DG as Deepgram
    participant GEM as Gemini

    Note over C146,API: Old flow (pre-revert hotfix — c720b65)
    C146->>API: GET /v1/config/api-keys
    API-->>C146: { deepgram_api_key, gemini_api_key, ... }
    C146->>DG: Direct call with key
    C146->>GEM: Direct call with key

    Note over C147,GEM: New flow (this PR — keys removed from config)
    C147->>API: GET /v1/config/api-keys
    API-->>C147: { anthropic_api_key, firebase_api_key, ... }
    C147->>API: POST /v1/proxy/deepgram/*
    API->>DG: Proxied request (key server-side)
    DG-->>API: Response
    API-->>C147: Response
    C147->>API: POST /v1/proxy/gemini/*
    API->>GEM: Proxied request (key server-side)
    GEM-->>API: Response
    API-->>C147: Response

    Note over C146: v0.11.146 auto-updates to v0.11.147 via Sparkle
Loading

Last reviewed commit: "Revert "Hotfix: rest..."

@beastoin beastoin merged commit f9421a0 into main Mar 21, 2026
3 checks passed
@beastoin beastoin deleted the revert/hotfix-config-keys branch March 21, 2026 09:41
@beastoin
Copy link
Copy Markdown
Collaborator Author

lgtm

Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
…dHardware#5879)

## Summary
- Reverts commit c720b65 which was incorrectly pushed directly to main
- Removes `deepgram_api_key` and `gemini_api_key` from
`/v1/config/api-keys` response
- v0.11.147 clients use `/v1/proxy/*` endpoints instead — old clients
will auto-update via Sparkle

## Why
The hotfix was unnecessary. v0.11.147 (with proxy support) is building
via Codemagic and will auto-update all users via Sparkle. No need to
maintain backward compat for v0.11.146.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

_by AI for @beastoin_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant