Skip to content

Fix plugins Cloud Run deploy: remove broken mentor import#5883

Merged
beastoin merged 1 commit intomainfrom
fix/plugins-mentor-broken-import
Mar 21, 2026
Merged

Fix plugins Cloud Run deploy: remove broken mentor import#5883
beastoin merged 1 commit intomainfrom
fix/plugins-mentor-broken-import

Conversation

@beastoin
Copy link
Copy Markdown
Collaborator

Summary

  • Remove broken from notifications.mentor import main as omi_mentor import in plugins/main.py
  • Remove corresponding app.include_router(omi_mentor.router) registration

Root Cause

Commit 2bce7af29 (Feb 20, @kodjima33) renamed plugins/notifications/mentor/plugins/notifications/mentor (deprecated)/ but did not update plugins/main.py. The import on line 14 still referenced the old path, causing the plugins Cloud Run service to fail on every deploy since Feb 21.

Why removal (not path fix)

The commit message for 2bce7af29 states: "Mentor app functionality has been integrated into Omi core". The mentor plugin is deprecated — the correct fix is to remove the dead import, not restore the old directory.

Changes

File Change
plugins/main.py Delete import line 14 + router registration line 95

Test plan

  • Verified no other files reference notifications.mentor
  • Two-line deletion, no new code paths

by AI for @beastoin

🤖 Generated with Claude Code

The mentor directory was renamed to 'mentor (deprecated)/' in 2bce7af
but the import in main.py was not updated, causing Cloud Run deploy
failures since Feb 21. Mentor functionality is now in Omi core.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator Author

@beastoin beastoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@beastoin beastoin merged commit 29a1394 into main Mar 21, 2026
2 of 3 checks passed
@beastoin beastoin deleted the fix/plugins-mentor-broken-import branch March 21, 2026 11:11
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 21, 2026

Greptile Summary

This PR fixes a broken import in plugins/main.py that has been causing the plugins Cloud Run service to fail on every deploy since Feb 21. Commit 2bce7af29 renamed plugins/notifications/mentor/ to plugins/notifications/mentor (deprecated)/ without updating the import in main.py, leaving a stale reference that threw an ImportError at startup.

Key changes:

  • Removes from notifications.mentor import main as omi_mentor (the path no longer resolves)
  • Removes the corresponding app.include_router(omi_mentor.router) registration

Notes:

  • The separate from basic import mentor as basic_realtime_mentor_router (line 26) and its router registration (line 74) are unrelated — plugins/basic/mentor.py exists and is healthy; no action needed there.
  • The PR correctly chooses removal over restoration, consistent with the deprecation intent stated in 2bce7af29.
  • No new code paths are introduced; this is a pure clean-up.

Confidence Score: 5/5

  • Safe to merge — minimal two-line deletion that removes a broken import with no side-effects.
  • The change is a focused removal of a dead import whose source directory no longer exists. No new logic is introduced, no other files are touched, and the remaining basic/mentor.py import is unaffected. The fix directly unblocks a deploy regression with zero risk of regressions.
  • No files require special attention.

Important Files Changed

Filename Overview
plugins/main.py Removes the broken from notifications.mentor import main as omi_mentor import and its corresponding app.include_router(omi_mentor.router) registration — a clean two-line fix that unblocks Cloud Run deployments since commit 2bce7af29 renamed the directory to notifications/mentor (deprecated)/.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[plugins/main.py startup] --> B[Import routers]
    B --> C[basic_conversation_created_router]
    B --> D[oauth_conversation_created_router]
    B --> E[zapier_conversation_created_router]
    B --> F[chatgpt_router]
    B --> G[subscription_router]
    B --> H[hey_omi]
    B --> I[basic_realtime_mentor_router\nbasic/mentor.py ✅]
    B --> J[iq_rating_router]
    B --> K[multion_router]

    B -. REMOVED .-> L["notifications.mentor ❌\n(directory renamed/deprecated)"]

    style L fill:#ffcccc,stroke:#ff0000,color:#000
    style I fill:#ccffcc,stroke:#00aa00,color:#000
Loading

Last reviewed commit: "Remove deprecated me..."

Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant