Skip to content

fix(desktop): start screen capture after chat onboarding step #5967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodjima33 merged 1 commit into from
Mar 24, 2026
Merged

fix(desktop): start screen capture after chat onboarding step #5967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions desktop/Desktop/Sources/OnboardingView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,17 @@ struct OnboardingView: View {
graphViewModel: graphViewModel,
onComplete: {
AnalyticsManager.shared.onboardingStepCompleted(step: 0, stepName: "Chat")
// Start screen capture early so Rewind tab has screenshots by the time
// the user finishes onboarding (permissions are granted during chat step)
if !ProactiveAssistantsPlugin.shared.isMonitoring {
ProactiveAssistantsPlugin.shared.startMonitoring { _, _ in }
}
currentStep = 1
},
onSkip: {
if !ProactiveAssistantsPlugin.shared.isMonitoring {
ProactiveAssistantsPlugin.shared.startMonitoring { _, _ in }
}
currentStep = 1
Comment on lines 91 to 95
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing analytics for skip path

The onSkip handler starts monitoring but does not record an analytics event for step 0 being skipped, while steps 1 and 2 both call AnalyticsManager.shared.onboardingStepCompleted with a _Skipped suffix in their onSkip closures. This is pre-existing, but the PR adds monitoring to the skip path without closing the gap.

Consider adding:

Suggested change
onSkip: {
if !ProactiveAssistantsPlugin.shared.isMonitoring {
ProactiveAssistantsPlugin.shared.startMonitoring { _, _ in }
}
currentStep = 1
onSkip: {
AnalyticsManager.shared.onboardingStepCompleted(step: 0, stepName: "Chat_Skipped")
if !ProactiveAssistantsPlugin.shared.isMonitoring {
ProactiveAssistantsPlugin.shared.startMonitoring { _, _ in }
}
currentStep = 1
}

}
)
Expand Down
Loading