Skip to content

fix(desktop): hide app extension in DMG + trigger build#6002

Merged
kodjima33 merged 1 commit into
mainfrom
worktree-fix-auth-activate-app
Mar 24, 2026
Merged

fix(desktop): hide app extension in DMG + trigger build#6002
kodjima33 merged 1 commit into
mainfrom
worktree-fix-auth-activate-app

Conversation

@kodjima33
Copy link
Copy Markdown
Collaborator

Triggers Codemagic build to test dmgbuild DMG fix (v0.11.167-168 were dropped).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@kodjima33 kodjima33 merged commit a539b53 into main Mar 24, 2026
@kodjima33 kodjima33 deleted the worktree-fix-auth-activate-app branch March 24, 2026 16:53
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 24, 2026

Greptile Summary

This PR adds a single hide_extensions setting to desktop/dmg-assets/dmgbuild_settings.py so that the .app extension is hidden for the application icon in the DMG Finder window — a standard macOS installer convention. The PR also serves as a Codemagic build trigger after versions v0.11.167-168 were dropped.

  • hide_extensions = [app_name + ".app"] is added, using exactly the same pattern already present in icon_locations, keeping the configuration consistent.
  • The setting is placed in a logical position between icon layout and volume icon configuration.
  • No functional or logic issues found; the change is minimal, correct, and well-scoped.

Confidence Score: 5/5

  • Safe to merge — single-line config addition with no side-effects beyond hiding the .app extension label in the DMG window.
  • The change is a one-liner that uses an established pattern already present in the same file (icon_locations uses the identical app_name + ".app" expression). The hide_extensions key is a standard dmgbuild setting. No logic, security, or data-loss risk involved.
  • No files require special attention.

Important Files Changed

Filename Overview
desktop/dmg-assets/dmgbuild_settings.py Adds hide_extensions setting so the .app suffix is hidden for the app icon in the DMG Finder window — consistent with how icon_locations already references the same app_name + ".app" key.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Codemagic CI build] --> B[dmgbuild invoked with\napp_path, app_name, assets_dir]
    B --> C[dmgbuild_settings.py evaluated]
    C --> D[files = app_path included]
    C --> E[icon_locations: app placed at 155,175\nApplications symlink at 455,175]
    C --> F[hide_extensions: app_name + '.app'\nhides .app suffix in Finder window]
    C --> G[background & volume icon applied]
    D & E & F & G --> H[dmgbuild writes .DS_Store directly]
    H --> I[Compressed UDBZ DMG output]
Loading

Reviews (1): Last reviewed commit: "fix(desktop): hide app extension in DMG ..." | Re-trigger Greptile

Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
…e#6002)

Triggers Codemagic build to test dmgbuild DMG fix (v0.11.167-168 were
dropped).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant