revert: restore create-dmg in codemagic.yaml

[kodjima33]

Reverting dmgbuild change — Codemagic stopped building after the switch. Restoring exact config from v0.11.166 (last successful build).

[greptile-apps]

Greptile Summary

This PR reverts the DMG creation toolchain for macOS desktop builds from dmgbuild (a Python package that writes .DS_Store directly) back to create-dmg (installed via Homebrew), restoring the configuration from v0.11.166 — the last known-good build. The dmgbuild_settings.py settings file is removed, the background image is reverted, and both affected Codemagic workflows are updated to install and invoke create-dmg with the original argument set (including --skip-jenkins to avoid AppleScript timeouts in CI).

Key observations:

• The two workflows are treated slightly differently: the first uses brew install create-dmg (no error guard), while the second uses brew install create-dmg || true. If create-dmg is already present in the Codemagic build cache, the first workflow's install step will exit non-zero and fail the build — the || true guard should be added for consistency.
• The --skip-jenkins flag was the mechanism relied upon to prevent AppleScript hangs the first time this config was used; the PR author confirms it was working in v0.11.166, so this is expected to hold.
• $BG_ARGS in the second workflow's create-dmg invocation is intentionally unquoted to allow word-splitting when the variable is empty; this is safe given the fixed path, but worth noting as a pattern to watch if the path ever gains spaces.

Confidence Score: 4/5

• Safe to merge after adding || true to the first workflow's brew install create-dmg step.
• This is a targeted revert to a known-working CI configuration. The changes are straightforward and well-scoped. The single concrete issue — a missing || true guard on brew install in the first workflow — could cause a spurious build failure if create-dmg is already cached, but it is a one-line fix and doesn't affect correctness of the DMG artifact itself.
• codemagic.yaml line 1476 — brew install create-dmg needs || true to match the second workflow and avoid failures when the package is already installed.

Important Files Changed

Filename	Overview
codemagic.yaml	Reverts DMG creation from dmgbuild (Python) back to create-dmg (Homebrew) for both macOS workflows. One minor inconsistency: the first workflow's brew install create-dmg lacks the `
desktop/dmg-assets/background.png	Binary background image reverted to the v0.11.166 version; no logic concerns.
desktop/dmg-assets/dmgbuild_settings.py	Python settings file for dmgbuild removed as part of the revert — no longer needed now that create-dmg is used.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Codemagic macOS Build] --> B[Notarize and Staple App]
    B --> C[Install create-dmg via brew]
    C --> D[Create DMG with create-dmg and --skip-jenkins]
    D --> E[Sign DMG via codesign]
    E --> F[Notarize DMG via notarytool]
    F --> G[Staple DMG via stapler]
    G --> H[Upload Artifact]

    C --> W1[Workflow 1: brew install create-dmg - missing OR true guard]
    C --> W2[Workflow 2: brew install create-dmg OR true - safe]

    W1 --> D
    W2 --> D

Loading

_{Reviews (1): Last reviewed commit: "revert: restore create-dmg in codemagic...." | Re-trigger Greptile}

[greptile-apps]

Missing || true on brew install

brew install exits with a non-zero status code when the package is already installed (common on Codemagic agents that cache Homebrew packages between builds). Without || true, this step will mark the build as failed and stop the pipeline.

The second workflow (line 2300) already uses || true for the same reason — this first workflow should be consistent:

Suggested change

	brew install create-dmg
	brew install create-dmg || true