-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: DMG installer arrow background using dmgbuild #6008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,51 @@ | ||||||||||
| # dmgbuild settings for OMI Desktop installer | ||||||||||
| # Usage: dmgbuild -s dmgbuild_settings.py -D app_path=/path/to/Omi.app -D app_name=omi "Omi" output.dmg | ||||||||||
| # | ||||||||||
| # This replaces create-dmg + AppleScript (which fails in CI due to --skip-jenkins). | ||||||||||
| # dmgbuild writes .DS_Store directly — no Finder/AppleScript needed. | ||||||||||
|
|
||||||||||
| import os | ||||||||||
|
|
||||||||||
| app_path = defines.get("app_path", "Omi.app") | ||||||||||
| app_name = defines.get("app_name", "omi") | ||||||||||
| # __file__ is not set when executed by dmgbuild; use defines or fall back to cwd | ||||||||||
| _script_dir = defines.get("assets_dir", os.path.join(os.getcwd(), "dmg-assets")) | ||||||||||
| bg_path = defines.get("background", os.path.join(_script_dir, "background.png")) | ||||||||||
| icon_path = defines.get("volume_icon", None) | ||||||||||
|
|
||||||||||
| # Volume settings | ||||||||||
| format = "UDBZ" # bzip2 compressed | ||||||||||
| size = None # auto-calculate | ||||||||||
| filesystem = "HFS+" | ||||||||||
|
|
||||||||||
| # Files to include | ||||||||||
| files = [app_path] | ||||||||||
| symlinks = {"Applications": "/Applications"} | ||||||||||
|
|
||||||||||
| # Window settings | ||||||||||
| background = bg_path | ||||||||||
| show_status_bar = False | ||||||||||
| show_tab_view = False | ||||||||||
| show_toolbar = False | ||||||||||
| show_pathbar = False | ||||||||||
| show_sidebar = False | ||||||||||
| sidebar_width = 0 | ||||||||||
|
|
||||||||||
| window_rect = ((200, 120), (610, 365)) | ||||||||||
| default_view = "icon-view" | ||||||||||
|
|
||||||||||
| icon_size = 80 | ||||||||||
| text_size = 12 | ||||||||||
|
|
||||||||||
| # Icon positions — must match background.png arrow (left=app, right=Applications) | ||||||||||
| icon_locations = { | ||||||||||
| app_name + ".app": (155, 175), | ||||||||||
| "Applications": (455, 175), | ||||||||||
| } | ||||||||||
|
|
||||||||||
| # Hide extension for the app | ||||||||||
| hide_extensions = [app_name + ".app"] | ||||||||||
|
|
||||||||||
| # Volume icon | ||||||||||
| if icon_path: | ||||||||||
| badge_icon = icon_path | ||||||||||
|
Comment on lines
+50
to
+51
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
This code path is currently dormant — neither workflow passes |
||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dmgbuildinstallpip3 install --break-system-packages dmgbuildinstalls the latest available release on every build with no version pin. A breaking change in a futuredmgbuildrelease could silently corrupt the DMG layout or fail the build. Consider pinning to a known-good version:The same applies to the second workflow's identical install line (line 2289).