Skip to content

Move Wi-Fi sync option from Customization to Hardware section#6126

Merged
aaravgarg merged 1 commit into
mainfrom
atlas/wifi-sync-to-hardware
Mar 28, 2026
Merged

Move Wi-Fi sync option from Customization to Hardware section#6126
aaravgarg merged 1 commit into
mainfrom
atlas/wifi-sync-to-hardware

Conversation

@aaravgarg
Copy link
Copy Markdown
Collaborator

Moves the Wi-Fi sync setting from the Customization section to the Hardware section in device settings, where it logically belongs.

Co-authored-by: Aarav Garg <aaravgarg@users.noreply.github.com>
@aaravgarg aaravgarg merged commit 957f3d7 into main Mar 28, 2026
@aaravgarg aaravgarg deleted the atlas/wifi-sync-to-hardware branch March 28, 2026 15:32
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 28, 2026

Greptile Summary

This PR moves the Wi-Fi sync informational row from the "Customization" section to the "Hardware Info" section in device_settings.dart. The change is purely cosmetic — the same conditional (_isWifiSupported), the same widget call (_buildProfileStyleItem with showChevron: false and no onTap), and the same l10n strings are used. Placing a device capability indicator alongside hardware revision, model number, and manufacturer is logically consistent with the existing section structure.

Key observations:

  • The _isWifiSupported flag is populated asynchronously in _loadInitialDimRatio() via connection.isWifiSyncSupported(); its initial value of false means the row is hidden until the BLE query resolves — behaviour is unchanged by this move.
  • The Wi-Fi sync row has no onTap and showChevron: false, making it purely informational both before and after this PR.
  • The trailing divider is correctly rendered only when the row is visible (if (_isWifiSupported) ...[Divider, item]), consistent with the pattern used for other conditional rows in the file.
  • All user-facing strings continue to use context.l10n.*, in compliance with the Flutter localization guideline.

Confidence Score: 5/5

Safe to merge — single-file UI reorganization with no logic changes or regressions.

The change is a straightforward cut-and-paste relocation of a UI block with no modifications to logic, state management, or widget behaviour. All existing guards and l10n patterns are preserved correctly.

No files require special attention.

Important Files Changed

Filename Overview
app/lib/pages/settings/device_settings.dart Wi-Fi sync UI block moved from _buildCustomizationSection to _buildHardwareInfoSection; no logic changes, purely a visual reorganization.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[DeviceSettings initState] --> B[_loadInitialDimRatio]
    B --> C{connection available?}
    C -- No --> D[nothing rendered]
    C -- Yes --> E[getFeatures]
    E --> F[isWifiSyncSupported]
    F --> G[setState _isWifiSupported]

    G --> H[_buildHardwareInfoSection]
    H --> I[Hardware Revision row]
    I --> J[Model Number row]
    J --> K[Manufacturer row]
    K --> L{_isWifiSupported?}
    L -- Yes --> M[Divider + Wi-Fi Sync row]
    L -- No --> N[section ends]

    style M fill:#2d5a27,color:#fff
    style N fill:#3a3a3a,color:#fff
Loading

Reviews (1): Last reviewed commit: "Move Wi-Fi sync from Customization to Ha..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant