Skip to content

Delete app/test_driver directory#6187

Merged
beastoin merged 1 commit into
mainfrom
beastoin-patch-2
Mar 31, 2026
Merged

Delete app/test_driver directory#6187
beastoin merged 1 commit into
mainfrom
beastoin-patch-2

Conversation

@beastoin
Copy link
Copy Markdown
Collaborator

No description provided.

@beastoin beastoin merged commit 13357e8 into main Mar 31, 2026
3 checks passed
@beastoin beastoin deleted the beastoin-patch-2 branch March 31, 2026 02:19
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 31, 2026

Greptile Summary

This PR removes app/test_driver/integration_test.dart, a three-line boilerplate Flutter integration test driver file that serves as the entry point for flutter drive commands. No CI workflows invoke flutter drive, so automated pipelines are unaffected.

Key points:

  • The deleted file is pure boilerplate (Future<void> main() => integrationDriver();) with no custom logic.
  • All four files in app/integration_test/ include doc comments instructing developers to run tests via flutter drive --driver=test_driver/integration_test.dart ... — those instructions will silently break once this file is gone.
  • Modern Flutter integration tests can be executed with flutter test integration_test/<file>.dart directly, which does not require the driver file. Updating the doc comments in the four integration test files to use flutter test instead would keep the instructions accurate.

Confidence Score: 5/5

Safe to merge — no CI workflows use the deleted driver file and no runtime behaviour is changed.

The only finding is a P2 style issue: four integration test files contain doc-comment run instructions that reference the now-deleted driver. This does not break any automated pipeline and does not affect app behaviour.

Consider updating the --driver=test_driver/integration_test.dart run instructions in all four app/integration_test/*.dart files.

Important Files Changed

Filename Overview
app/test_driver/integration_test.dart Deletes the 3-line boilerplate Flutter integration test driver file; referenced in doc comments of all 4 files in app/integration_test/ but not used by any CI workflow

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Developer runs integration tests] --> B{Method chosen}
    B -->|flutter test| C["flutter test integration_test/test.dart\n✅ Works without driver file"]
    B -->|flutter drive| D["flutter drive\n  --driver=test_driver/integration_test.dart\n  --target=integration_test/test.dart"]
    D --> E["❌ Driver file no longer exists\nWill fail with FileNotFoundError"]
    C --> F[Test runs successfully]
    G[CI Workflows] --> H["No flutter drive usage in any\n.github/workflows/*.yml\n✅ CI unaffected"]
Loading

Comments Outside Diff (1)

  1. app/test_driver/integration_test.dart

    P2 Stale --driver references in all integration test files

    Deleting this driver file leaves broken run instructions in the doc comments of every file under app/integration_test/. All four tests document flutter drive --driver=test_driver/integration_test.dart as the canonical way to run them:

    • integration_test/animation_performance_test.dart — line 15–19
    • integration_test/app_performance_test.dart — line 17–23
    • integration_test/shimmer_cpu_test.dart — line 14–21
    • integration_test/widget_rebuild_profiling_test.dart — line 17–24

    A developer who follows those instructions will now get a FileNotFoundException at startup. Since flutter test integration_test/<file>.dart works fine without a driver, consider updating those doc comments to use flutter test instead (or removing the flutter drive instructions).

Reviews (1): Last reviewed commit: "Delete app/test_driver directory" | Re-trigger Greptile

Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant