Skip to content

fix(ci): route Cloud Run traffic to latest revision on admin deploy#6270

Merged
beastoin merged 1 commit into
mainfrom
fix/admin-traffic-routing
Apr 2, 2026
Merged

fix(ci): route Cloud Run traffic to latest revision on admin deploy#6270
beastoin merged 1 commit into
mainfrom
fix/admin-traffic-routing

Conversation

@beastoin
Copy link
Copy Markdown
Collaborator

@beastoin beastoin commented Apr 2, 2026

Summary

  • Adds revision_traffic: LATEST=100 to the deploy-cloudrun step in gcp_admin.yml
  • Fixes traffic being pinned to old revision (00042 from private repo deploy) while new monorepo revisions deploy but don't serve

Context

The previous private repo deployment pinned traffic to revision 00042. When the monorepo workflow deploys new revisions, deploy-cloudrun@v2 doesn't override the existing traffic routing — so the old code keeps serving. This one-line fix ensures each deploy automatically routes 100% traffic to the newly deployed revision.

Test plan

  • Merge this PR — triggers gcp_admin.yml workflow
  • Verify workflow completes successfully
  • Verify admin.omi.me serves from the latest revision (check /dashboard/fair-use exists)

🤖 Generated with Claude Code

The previous private repo deployment pinned traffic to revision 00042.
Subsequent monorepo deploys create new revisions but don't override the
traffic routing, leaving the old code serving. Adding revision_traffic
ensures each deploy automatically routes 100% traffic to the new revision.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@beastoin beastoin merged commit a74379c into main Apr 2, 2026
3 checks passed
@beastoin beastoin deleted the fix/admin-traffic-routing branch April 2, 2026 02:37
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 2, 2026

Greptile Summary

This PR adds a single revision_traffic: LATEST=100 line to the deploy-cloudrun@v2 step in gcp_admin.yml, ensuring 100% of traffic is routed to the newly deployed revision on every push. The fix correctly resolves traffic being permanently pinned to a prior revision (00042) from the previous private-repo deployment, which left new monorepo revisions deploying but not actually serving traffic.

Confidence Score: 5/5

  • Safe to merge — minimal, targeted fix with no risk of regressions.
  • The change is a single-line addition of a well-documented deploy-cloudrun@v2 parameter. It resolves a clear, confirmed production traffic routing issue and introduces no new logic or dependencies. All remaining considerations (e.g. other workflows lacking the same parameter) are pre-existing and out of scope.
  • No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/gcp_admin.yml Adds revision_traffic: LATEST=100 to the deploy-cloudrun step so every new deployment immediately serves 100% of traffic, fixing the stale-revision routing regression.

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions
    participant GCR as Google Container Registry
    participant CR as Cloud Run

    GH->>GCR: Build & push image (gcr.io/.../omi-admin-dashboard)
    GH->>CR: deploy-cloudrun@v2 (image + revision_traffic: LATEST=100)
    CR-->>CR: Create new revision (e.g. 00043)
    CR-->>CR: Route 100% traffic → latest revision
    CR-->>GH: Return service URL
    GH->>GH: echo deploy URL
Loading

Reviews (1): Last reviewed commit: "fix(ci): route Cloud Run traffic to late..." | Re-trigger Greptile

Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
…asedHardware#6270)

## Summary
- Adds `revision_traffic: LATEST=100` to the deploy-cloudrun step in
`gcp_admin.yml`
- Fixes traffic being pinned to old revision (00042 from private repo
deploy) while new monorepo revisions deploy but don't serve

## Context
The previous private repo deployment pinned traffic to revision 00042.
When the monorepo workflow deploys new revisions, `deploy-cloudrun@v2`
doesn't override the existing traffic routing — so the old code keeps
serving. This one-line fix ensures each deploy automatically routes 100%
traffic to the newly deployed revision.

## Test plan
- [ ] Merge this PR — triggers `gcp_admin.yml` workflow
- [ ] Verify workflow completes successfully
- [ ] Verify `admin.omi.me` serves from the latest revision (check
`/dashboard/fair-use` exists)

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant