Enable voice responses by default for voice questions

[kodjima33]

Summary

• Voice responses enabled by default for all users (was opt-in experimental)
• Only plays voice for voice (PTT) queries — typed questions get text-only responses
• Updated settings label from "Voice Answers (Experimental)" to "Voice Responses"
• Added "Enable voice responses" checkbox to onboarding voice demo step
• Onboarding title now shows the actual PTT key ("Hold Option and Ask" instead of "Hold and Ask")

Test plan

• PTT voice question → AI response spoken aloud
• Typed question → no audio response
• Toggle off in Settings → voice stops for all queries
• Onboarding checkbox controls the setting
• Onboarding title shows correct PTT key

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

This PR gates floating-bar voice responses to PTT (push-to-talk) queries only by tracking a currentQueryFromVoice flag per query, rather than playing voice for every query when the global toggle is on. It also enables voice responses by default (floatingBarVoiceAnswersEnabled default changed to true), updates the settings label, and adds a voice-responses checkbox to the onboarding voice-demo step.

Confidence Score: 5/5

Safe to merge — voice-gating logic is correct and all code paths stop prior playback before starting new queries

currentQueryFromVoice is properly set, propagated, and cleared in all code paths (openAIInputWithQuery, sendFollowUpQuery, clearVisibleConversation). sendAIQuery always calls FloatingBarVoicePlaybackService.shared.stop() first so typed queries naturally halt any in-progress voice. The default-true migration is correct: new users get true, existing users who never touched the setting also get true (key absent in UserDefaults), and users who explicitly disabled it retain false. Only remaining finding is a P2 style issue in OnboardingVoiceDemoView.

desktop/Desktop/Sources/OnboardingVoiceDemoView.swift — @State voiceResponsesEnabled could be refactored to bind directly to ShortcutSettings

Important Files Changed

Filename	Overview
desktop/Desktop/Sources/FloatingControlBar/FloatingControlBarState.swift	Added currentQueryFromVoice published property; correctly reset in clearVisibleConversation()
desktop/Desktop/Sources/FloatingControlBar/FloatingControlBarWindow.swift	openAIInputWithQuery and sendFollowUpQuery accept fromVoice; shouldPlayVoice captured from currentQueryFromVoice at send time; existing stop() prevents stale playback
desktop/Desktop/Sources/FloatingControlBar/PushToTalkManager.swift	sendTranscript passes fromVoice:true to both openAIInputWithQuery and sendFollowUpQuery
desktop/Desktop/Sources/FloatingControlBar/ShortcutSettings.swift	floatingBarVoiceAnswersEnabled default changed to true; existing users with explicit false retain their preference
desktop/Desktop/Sources/MainWindow/Pages/SettingsPage.swift	Label updated to 'Voice Responses' with accurate description of per-query voice behaviour
desktop/Desktop/Sources/OnboardingVoiceDemoView.swift	Title now shows dynamic PTT key; voice checkbox added but uses @State that could drift from ShortcutSettings

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User holds PTT shortcut] --> B[PushToTalkManager.startListening]
    B --> C[FloatingBarVoicePlaybackService.stop]
    B --> D[Audio capture + live transcription]
    D --> E[sendTranscript fromVoice:true]
    E --> F[openAIInputWithQuery / sendFollowUpQuery]
    F --> G[currentQueryFromVoice = true]
    G --> H[sendAIQuery]
    H --> I[FloatingBarVoicePlaybackService.stop]
    I --> J{shouldPlayVoice = currentQueryFromVoice AND voiceAnswersEnabled}
    J -->|true| K[playFillerIfEnabled]
    K --> L[AI streams response]
    L --> M[updateStreamingResponseIfEnabled]
    M --> N[Voice spoken aloud]
    J -->|false| O[Text-only response]
    P[User types query] -->|fromVoice:false| F2[openAIInputWithQuery]
    F2 --> G2[currentQueryFromVoice = false]
    G2 --> H

Loading

_{Reviews (1): Last reviewed commit: "Add voice responses checkbox and show PT..." | Re-trigger Greptile}

[greptile-apps]

Local @State can drift from ShortcutSettings

voiceResponsesEnabled is initialised once from ShortcutSettings.shared.floatingBarVoiceAnswersEnabled and is never re-synced if the setting is mutated externally (e.g. a SettingsSyncManager push after login completes during onboarding). The floatingBarVoiceAnswersBinding pattern already used in SettingsPage binds directly to the observed object and avoids the redundant state:

// In OnboardingVoiceDemoView — replace the @State and onChange with a binding helper:
private var floatingBarVoiceAnswersBinding: Binding<Bool> {
    Binding(
        get: { shortcutSettings.floatingBarVoiceAnswersEnabled },
        set: { newValue in
            shortcutSettings.floatingBarVoiceAnswersEnabled = newValue
            SettingsSyncManager.shared.pushPartialUpdate(
                AssistantSettingsResponse(
                    floatingBar: FloatingBarSettingsResponse(voiceAnswersEnabled: newValue)
                )
            )
        }
    )
}

Then bind the Toggle to floatingBarVoiceAnswersBinding and drop @State private var voiceResponsesEnabled.