Skip to content

fix(backend): use user's name in conversation title instead of "user" (#6216) #6843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −0
Open

fix(backend): use user's name in conversation title instead of "user" (#6216) #6843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d60759
fix(backend): use user's name in conversation title instead of "user"…
mvanhorn Apr 19, 2026
48b57fa
revert(backend): drop USER CONTEXT prompt addition per maintainer fee…
mvanhorn Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions backend/utils/conversations/process_conversation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ def _get_structured(
conversation.started_at,
language_code,
tz,
uid,
calendar_meeting_context=calendar_context,
output_language_code=user_language,
)
Expand Down Expand Up @@ -194,6 +195,7 @@ def _get_structured(
conversation.started_at,
language_code,
tz,
uid,
photos=conversation.photos,
calendar_meeting_context=calendar_context,
output_language_code=user_language,
Expand Down
7 changes: 7 additions & 0 deletions backend/utils/llm/conversation_processing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from langchain_core.prompts import ChatPromptTemplate
from pydantic import BaseModel, Field

from database.auth import get_user_name
from models.app import App
from models.calendar_context import CalendarMeetingContext
from models.conversation import Conversation
Expand Down Expand Up @@ -590,6 +591,7 @@ def get_transcript_structure(
started_at: datetime,
language_code: str,
tz: str,
uid: str,
photos: List[ConversationPhoto] = None,
calendar_meeting_context: 'CalendarMeetingContext' = None,
output_language_code: str = None,
Expand All @@ -599,6 +601,11 @@ def get_transcript_structure(
return Structured() # Should be caught by discard logic, but as a safeguard.

response_language = output_language_code or language_code
try:
user_name = get_user_name(uid)
except Exception as e:
logger.warning(f'Failed to load user name for transcript structuring (uid={uid}): {e}')
user_name = 'The User'
Comment on lines +604 to +608
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Redundant fallback — get_user_name already returns "The User" by default

get_user_name(uid) is called with use_default=True (the default), so it already returns 'The User' when no name is found. The try/except here catches only genuine runtime failures (Redis/Firestore I/O errors), which is fine for resilience — but the fallback value is already guaranteed by the function itself. Consider adding a comment explaining that the wrapper guards against network exceptions propagating out of get_user_from_uid, so future readers don't assume it is unnecessary.


# First system message: task-specific instructions (static prefix enables cross-conversation caching)
# NOTE: language instructions are in context_message (second message) to keep this prefix fully static.
Expand Down