Skip to content

Fix: reminder fires at wrong time for IST (UTC+5:30) users #7066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
priyadarshiutkarsh wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −10
Open

Fix: reminder fires at wrong time for IST (UTC+5:30) users #7066

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6f38c7
fixed : due_at handling to use local timezone
priyadarshiutkarsh Apr 28, 2026
9e9e74c
Fix indentation in due_at timezone conversion block
priyadarshiutkarsh Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions backend/utils/llm/conversation_processing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from datetime import datetime, timedelta, timezone
from typing import List, Optional, Tuple
from zoneinfo import ZoneInfo

from langchain_core.output_parsers import PydanticOutputParser
from langchain_core.prompts import ChatPromptTemplate
Expand Down Expand Up @@ -510,16 +511,16 @@ def extract_action_items(
• Order by: due date → urgency → alphabetical

DUE DATE EXTRACTION:
All due_at values MUST be future UTC timestamps with 'Z' suffix. NEVER produce a past date.
All due_at values MUST be future timestamps in the user's LOCAL timezone. NEVER produce a past date.

REFERENCE_TIME: If {started_at} is >7 days before {current_time}, use {current_time} (historical reprocessing). Otherwise use {started_at}.

Date resolution: "today" → REFERENCE_TIME date, "tomorrow" → next day, weekday names → next occurrence, "next week" → +7 days.
Time resolution: "morning" → 9AM, "afternoon" → 2PM, "evening" → 6PM, "noon" → 12PM, "end of day"/"midnight" → 11:59PM, no time → 11:59PM. "urgent"/"ASAP" → 2h from REFERENCE_TIME.
Process: resolve date + time in user's timezone ({tz}), convert to UTC with 'Z' suffix, verify it's future relative to {current_time}. If past, omit due_at.

Example: REFERENCE_TIME "2025-10-03T13:25:00Z", tz "Asia/Kolkata": "tomorrow before 10am" → Oct 4 10:00 IST → "2025-10-04T04:30:00Z"
Format: UTC with 'Z' suffix only (e.g., "2025-10-04T04:30:00Z"). No timezone offsets like "+05:30".
Process: resolve date + time in user's LOCAL timezone ({tz}). Do NOT convert to UTC. Output the local time exactly as the user would see it.
Example: REFERENCE_TIME "2025-10-03T13:25:00Z", tz "Asia/Kolkata": "tomorrow before 10am" → Oct 4 10:00 IST → "2025-10-04T10:00:00"
Format: Local time with NO timezone suffix (e.g., "2025-10-04T10:00:00"). Do NOT include 'Z' or any offset like "+05:30".

Conversation started at: {started_at}
Current time: {current_time}
Comment on lines 525 to 526
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 LLM still receives UTC reference times but must reason in local time

started_at and current_time are passed as UTC ISO strings (e.g., "2025-10-03T13:25:00Z"), but the prompt now asks the LLM to resolve "today" / "tomorrow" in the user's local timezone without converting its output to UTC. The LLM still has to mentally shift REFERENCE_TIME from UTC to local time to determine the correct calendar date (e.g., 13:25 UTC = 18:55 IST, so "tomorrow" is Oct 4 IST, not Oct 3). Passing local-time reference values (pre-converted in Python) would make the LLM's job unambiguous and reduce the remaining surface for off-by-one-day errors near midnight boundaries.

Expand Down Expand Up @@ -557,16 +558,21 @@ def extract_action_items(
for action_item in response.action_items or []:
if action_item.created_at is None:
action_item.created_at = now
# Post-extraction validation: clear due dates more than 1 day in the past
if action_item.due_at is not None:
due_utc = (
action_item.due_at if action_item.due_at.tzinfo else action_item.due_at.replace(tzinfo=timezone.utc)
)
if due_utc < now - timedelta(days=1):
if action_item.due_at.tzinfo is None:
try:
user_tz = ZoneInfo(tz) if tz else timezone.utc
action_item.due_at = action_item.due_at.replace(tzinfo=user_tz).astimezone(timezone.utc)
except Exception:
action_item.due_at = action_item.due_at.replace(tzinfo=timezone.utc)
else:
action_item.due_at = action_item.due_at.astimezone(timezone.utc)
if action_item.due_at < now - timedelta(days=1):
logger.warning(
f'Clearing past due_at {action_item.due_at.isoformat()} for action item: {action_item.description}'
)
action_item.due_at = None


return response.action_items or []

Expand Down