Skip to content

Add 14 missing l10n translations across 48 locales#7128

Merged
mdmohsin7 merged 1 commit intomainfrom
fix/app-missing-l10n-translations
May 2, 2026
Merged

Add 14 missing l10n translations across 48 locales#7128
mdmohsin7 merged 1 commit intomainfrom
fix/app-missing-l10n-translations

Conversation

@mdmohsin7
Copy link
Copy Markdown
Member

Summary

  • Adds 14 missing translation keys to all 48 non-English ARB locale files
  • Resolves flutter gen-l10n untranslated message warnings
  • Keys added: bulkExportInProgress, bulkExportPartial, bulkExportSuccess, chooseExportDestination, connectAction, connectTaskAppToExport, deselectAllTasksMenu, hideCompletedTasks, searchActionItems, selectActionItems, selectAllTasksMenu, showCompletedTasks, startCallRecording, startVoiceRecording

Test plan

  • flutter gen-l10n passes with zero untranslated warnings
  • All 48 locale files validated as valid JSON
  • All ICU placeholders ({success}, {total}, {platform}, {count}) preserved in every translation
  • Smoke test app in a non-English locale to verify strings render

Keys: bulkExportInProgress, bulkExportPartial, bulkExportSuccess,
chooseExportDestination, connectAction, connectTaskAppToExport,
deselectAllTasksMenu, hideCompletedTasks, searchActionItems,
selectActionItems, selectAllTasksMenu, showCompletedTasks,
startCallRecording, startVoiceRecording
@mdmohsin7
Copy link
Copy Markdown
Member Author

morpheus review — omi#7128

Verdict: Approved

Mechanical l10n addition — 14 keys across 48 locales + 48 generated dart files. One commit, clean scope.

Checks run

Leaks: N/A — translation strings only.

Correctness:

  • ICU placeholders ({success}, {total}, {platform}, {count}) verified across sampled locales (ar, bn, de, es, fa, fr, hi). All present and correctly positioned within translated strings. ✓
  • flutter gen-l10n passes with zero warnings per PR body. Generated .dart files are consistent with ARB source. ✓
  • Structure consistent across all 48 files: +15/-1 (trailing comma fix + 14 new keys). ✓

Translation quality spot-check:

  • es/fr/de: verified correct translations for export, connect, search, recording terms. ✓

Scope: No code changes. ARB + generated dart files only. ✓

No blockers.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 2, 2026

Greptile Summary

This PR adds 14 missing translation keys (bulkExportInProgress, bulkExportPartial, bulkExportSuccess, chooseExportDestination, connectAction, connectTaskAppToExport, deselectAllTasksMenu, hideCompletedTasks, searchActionItems, selectActionItems, selectAllTasksMenu, showCompletedTasks, startCallRecording, startVoiceRecording) to all 48 non-English ARB locale files, along with the corresponding auto-generated Dart localization classes. All ICU placeholders ({success}, {total}, {platform}, {count}) are correctly preserved across every locale, and the changes resolve the pre-existing English fallback strings that were previously committed to the generated .dart files.

Confidence Score: 4/5

Safe to merge — changes are purely additive l10n data with no runtime logic; all placeholders are technically correct.

All 48 ARB files and corresponding generated Dart files are updated consistently. All parameterised strings preserve their placeholders. The only concern is translation quality (P2): the strings appear to be machine-translated without native-speaker review, and at least one term (connectAction in Arabic, "اتصال") is ambiguous. No runtime errors or data loss risk.

No files require special attention from a correctness standpoint; native-speaker review of high-traffic locales (ar, zh, hi, ru, pt) would improve translation quality.

Important Files Changed

Filename Overview
app/lib/l10n/app_ar.arb Adds 14 Arabic translation keys; all placeholders preserved, but connectAction ("اتصال") may be ambiguous — it also means "phone call" in Arabic.
app/lib/l10n/app_de.arb Adds 14 translation keys for German; all placeholders ({success}, {total}, {platform}, {count}) preserved, translations are contextually accurate.
app/lib/l10n/app_zh.arb Adds 14 Chinese translation keys; bulkExportPartial uses slash format ({success}/{total}) instead of "of" — a legitimate CJK style choice, consistent with Dart file.
app/lib/l10n/app_fr.arb Adds 14 French translation keys; translations are idiomatic and all ICU placeholders are correctly preserved.
app/lib/l10n/app_ja.arb Adds 14 Japanese translation keys; uses natural Japanese word order for parameterized strings ({total}件中{success}件), all placeholders present.
app/lib/l10n/app_ru.arb Adds 14 Russian translation keys; all placeholders preserved, translations are grammatically appropriate.
app/lib/l10n/app_localizations_de.dart Auto-generated Dart localizations for German updated to match ARB translations; all method signatures (parameterized and non-parameterized) are correct.
app/lib/l10n/app_localizations_ar.dart Auto-generated Dart localizations for Arabic; all 14 methods updated, Dart string interpolation ($var) correctly matches ARB placeholders ({var}).

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    EN["app_en.arb\n(source — 14 new keys)"]
    ARB["48 × app_XX.arb\n(translated ARB files)"]
    GEN["flutter gen-l10n"]
    DART["48 × app_localizations_XX.dart\n(generated Dart classes)"]
    APP["Flutter App\nAppLocalizations.of(context).keyName"]

    EN -->|"translation added\n(machine + review)"| ARB
    ARB --> GEN
    GEN --> DART
    DART --> APP
Loading

Comments Outside Diff (1)

  1. app/lib/l10n/app_ar.arb, line 1 (link)

    P2 Machine-translated strings may lack native-speaker review

    All 48 locales were updated in a single PR, which strongly suggests automated (machine) translation rather than human-reviewed translations. Several entries show signs of this: the Arabic connectAction is translated as "اتصال" (which primarily means "phone call/communication") rather than the more accurate verb form "ربط" or "اتصل" for the action "Connect". Similarly, other locales like Bengali, Bosnian, and Macedonian follow identical sentence structures that suggest MT output. While placeholders are all technically preserved, translation quality should ideally be verified by native speakers for at least the highest-traffic languages (ar, zh, fr, de, es, hi, pt, ru).

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Reviews (1): Last reviewed commit: "Add 14 missing l10n translations across ..." | Re-trigger Greptile

@mdmohsin7 mdmohsin7 merged commit 51a1fb6 into main May 2, 2026
2 of 3 checks passed
@mdmohsin7 mdmohsin7 deleted the fix/app-missing-l10n-translations branch May 2, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant