Skip to content

Upgrade compileSdkVersion to 31#89

Merged
mvanbeusekom merged 1 commit intoBaseflow:masterfrom
internetstores:master
Mar 8, 2022
Merged

Upgrade compileSdkVersion to 31#89
mvanbeusekom merged 1 commit intoBaseflow:masterfrom
internetstores:master

Conversation

@lohanbodevan
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

This PR fixes #87 which prevents, Flutter apps compiling to Android SDK 31, to build.

⤵️ What is the current behavior?

Build fails for Flutter applications compiling for Android SDK 31

🆕 What is the new behavior (if this is a feature change)?

Build works fine for flutter applications compiling for Android SDK 31

💥 Does this PR introduce a breaking change?

Yes, current clients must also upgrade to compileSdkVersion 31 on android/app/build.gradle, when using this version of flutter-geocoding

🐛 Recommendations for testing

Run example app or any other application on Android device/emulator with compileSdkVersion 31 on android/app/build.gradle

📝 Links to relevant issues/docs

None

🤔 Checklist before submitting

  • I made sure all projects build.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I followed the style guide lines (code style guide).
  • I updated the relevant documentation.
  • I rebased onto current master.

@lohanbodevan lohanbodevan changed the title Upgrade compileSdkVersion from 30 to 31 Upgrade compileSdkVersion to 31 Mar 8, 2022
Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for this contribution

@mvanbeusekom mvanbeusekom merged commit 171e795 into Baseflow:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to build for targetSdkVersion and compileSdkVersion 31

2 participants