-
-
Notifications
You must be signed in to change notification settings - Fork 912
Added manage external storage permission #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
============================================
- Coverage 100.00% 87.91% -12.09%
============================================
Files 1 6 +5
Lines 16 91 +75
============================================
+ Hits 16 80 +64
- Misses 0 11 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just wanted to bump the version as a feature (so to 3.2.0).
| # NOTE: We strongly prefer non-breaking changes, even at the expense of a | ||
| # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes | ||
| version: 3.1.3 | ||
| version: 3.1.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can update this as a new feature release:
| version: 3.1.4 | |
| version: 3.2.0 |
| @@ -1,3 +1,7 @@ | |||
| ## 3.1.4 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should introduce this as a new feature release:
| ## 3.1.4 | |
| ## 3.2.0 |
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Introduces the 'Manage External Storage' permission
🆕 What is the new behavior (if this is a feature change)?
💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
📝 Links to relevant issues/docs
🤔 Checklist before submitting
master.