nnbd Firebase #306
Closed
nnbd Firebase #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make FirebaseCacheManager._instance final and initialize it * Migrate FirebaseHttpFileService.get to nnbd
sidrao2006
commented
May 3, 2021
| {Map<String, String> headers = const {}}) async { | ||
| {Map<String, String>? headers = const {}}) async { | ||
| var ref = FirebaseStorage.instance.ref().child(url); | ||
| var _url = await ref.getDownloadURL() as String; |
Contributor
Author
There was a problem hiding this comment.
@renefloor was there any specific reason for this cast?
Contributor
Author
|
Depends on #305 for updated dependencies |
…ager into nnbd-firebase
Contributor
|
Thanks, but I'll close this as #295 was just a bit earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Null safety migration
💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
📝 Links to relevant issues/docs
Fixes #276
🤔 Checklist before submitting