Skip to content

nnbd Firebase #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

nnbd Firebase #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b032f5
refactor: Remove unnecessary cast
sidrao2006 Apr 9, 2021
51c8bdc
build(dependency): Update version constraints
sidrao2006 Apr 9, 2021
6e9e0d5
build: Update SDK constraints
sidrao2006 Apr 9, 2021
61e13bc
feat(nnbd): Migrate to null safety
sidrao2006 Apr 9, 2021
b84501a
Merge branch 'develop' of git://github.com/Baseflow/flutter_cache_man…
sidrao2006 May 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions flutter_cache_manager_firebase/lib/src/firebase_cache_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@ import 'firebase_http_file_service.dart';
class FirebaseCacheManager extends CacheManager {
static const key = 'firebaseCache';

static FirebaseCacheManager _instance;
static final FirebaseCacheManager _instance = FirebaseCacheManager._();

factory FirebaseCacheManager() {
_instance ??= FirebaseCacheManager._();
return _instance;
}

Expand Down
4 changes: 2 additions & 2 deletions flutter_cache_manager_firebase/lib/src/firebase_http_file_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import 'package:flutter_cache_manager/flutter_cache_manager.dart';
class FirebaseHttpFileService extends HttpFileService {
@override
Future<FileServiceResponse> get(String url,
{Map<String, String> headers = const {}}) async {
{Map<String, String>? headers = const {}}) async {
var ref = FirebaseStorage.instance.ref().child(url);
var _url = await ref.getDownloadURL() as String;
Copy link
Contributor Author

@sidrao2006 sidrao2006 May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renefloor was there any specific reason for this cast?

var _url = await ref.getDownloadURL();

return super.get(_url);
}
Expand Down
10 changes: 5 additions & 5 deletions flutter_cache_manager_firebase/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ version: 1.1.0
homepage: https://github.com/Baseflow/flutter_cache_manager

environment:
sdk: ">=2.7.0 <3.0.0"
sdk: '>=2.12.0 <3.0.0'

dependencies:
flutter:
sdk: flutter
flutter_cache_manager: ^2.0.0
firebase_storage: ">=3.0.0 <6.0.0"
path_provider: "^1.4.0"
path: "^1.6.4"
flutter_cache_manager: ^3.0.1
firebase_storage: ">=3.0.0 <9.0.0"
path_provider: ^2.0.1
path: ^1.8.0

dev_dependencies:
flutter_test:
Expand Down