Conversation
tluijken
approved these changes
May 14, 2024
tluijken
requested changes
May 14, 2024
| @@ -1,3 +1,4 @@ | |||
| cd stellar_rust_sdk | |||
Collaborator
There was a problem hiding this comment.
Dit kan, maar is niet zo fraai. Mooiste is om cargo test met een manifest file aan te roepen. Mocht je relatieve paden met dependencies hebben (zoals de derive crate) dan werkt dat ook mooi. Zie onderstaande suggestie.
| @@ -1,3 +1,4 @@ | |||
| cd stellar_rust_sdk | |||
| CARGO_INCREMENTAL=0 RUSTFLAGS='-Cinstrument-coverage' LLVM_PROFILE_FILE='cargo-test-%p-%m.profraw' cargo test | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| CARGO_INCREMENTAL=0 RUSTFLAGS='-Cinstrument-coverage' LLVM_PROFILE_FILE='cargo-test-%p-%m.profraw' cargo test | |
| CARGO_INCREMENTAL=0 RUSTFLAGS='-Cinstrument-coverage' LLVM_PROFILE_FILE='cargo-test-%p-%m.profraw' cargo test --manifest-path=stellar_rust_sdk/Cargo.toml |
Dit is ook in lijn met de github workflows voor dit project.
LeonardTibben
approved these changes
May 24, 2024
tluijken
approved these changes
May 27, 2024
tluijken
force-pushed
the
67-code-coverage-script
branch
from
7a7e459 to
81ef5d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Updates the shell script for checking the code coverage. Includes minor test value updates to prevent a blocked PR.
Fixes #67.
The script fails because it cannot find input files.
🆕 What is the new behavior (if this is a feature change)?
A simple directory change command at the beginning of the script.
💥 Does this PR introduce a breaking change?
No.
🤔 Checklist before submitting