fix(pruning): Filter non-existent S3/Azure partitions before query ex…#127
Merged
fix(pruning): Filter non-existent S3/Azure partitions before query ex…#127
Conversation
…ecution Time-filtered queries were failing when the requested range included partitions that don't exist in S3. The partition pruner was generating paths for all hours in the range without checking existence for remote storage (it only checked for local storage). Changes: - Add SetStorageBackend() to PartitionPruner for remote path validation - Implement filterExistingRemotePaths() using ListDirectories() to check which S3/Azure partition directories actually exist - Fix GeneratePartitionPaths() to preserve s3:// and azure:// URL scheme (was using filepath.Join which mangles URLs) - Wire up storage backend in QueryHandler When partitions are missing, queries now return partial results from existing partitions instead of failing entirely. This is critical for Grafana dashboards with "Last 30 days" time ranges where historical data may have gaps. Fixes #125
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ecution
Time-filtered queries were failing when the requested range included partitions that don't exist in S3. The partition pruner was generating paths for all hours in the range without checking existence for remote storage (it only checked for local storage).
Changes:
When partitions are missing, queries now return partial results from existing partitions instead of failing entirely. This is critical for Grafana dashboards with "Last 30 days" time ranges where historical data may have gaps.
Fixes #125