fix(ingest): prevent panic during high-concurrency writes with schema…#137
Merged
fix(ingest): prevent panic during high-concurrency writes with schema…#137
Conversation
… evolution Fix for Issue #130: Arrow writer panics with "index out of range" during high-concurrency writes when batches have different column sets. Root cause: mergeBatches() created columns of different lengths when batches had different schemas (e.g., some records had 'cpu' field, others had 'temperature'). When groupByHour() generated indices from the time column, accessing those indices on shorter columns caused panic. Changes: - mergeBatches(): Normalize all columns to same length (totalRows from time column), using zero values for sparse positions - sliceColumnsByIndices(): Add defensive bounds checking as safety layer - Add tests for sparse column handling Closes #130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… evolution
Fix for Issue #130: Arrow writer panics with "index out of range" during high-concurrency writes when batches have different column sets.
Root cause: mergeBatches() created columns of different lengths when batches had different schemas (e.g., some records had 'cpu' field, others had 'temperature'). When groupByHour() generated indices from the time column, accessing those indices on shorter columns caused panic.
Changes:
Closes #130