Merged
Conversation
Buffers configured with max_buffer_age_ms were flushing at up to 1.4x the configured time under high throughput scenarios. Root cause: Under heavy load, the periodic flush goroutine could be starved or delayed by intensive I/O operations and lock contention. With the ticker firing every max_buffer_age_ms (e.g., 5000ms), buffers created between ticker fires had to wait for the next check cycle. Fix: Fire the ticker every max_buffer_age_ms/2 (e.g., 2500ms) while keeping the age threshold at max_buffer_age_ms. This gives the periodic flush goroutine more opportunities to run even under heavy load, without flushing buffers prematurely. Impact: - Before: age=6700-7000ms (max_buffer_age_ms=5000) - After: age=5100-5700ms (max_buffer_age_ms=5000) - Improvement: ~1.5 seconds faster (25% improvement) - Throughput: Minimal impact (~1% overhead) Added comprehensive timing tests to verify behavior and prevent regressions. Relates to #142
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.