fix(wal): native columnar recovery, database envelope, and shutdown purge#173
Merged
fix(wal): native columnar recovery, database envelope, and shutdown purge#173
Conversation
…urge - WAL reader now handles both row and columnar entry formats natively, eliminating the row-conversion roundtrip during recovery - Database name is stored in WAL entries via an envelope format (0x01 marker + db name), enabling correct routing on recovery - AppendRawWithMeta builds WAL entries in a single allocation to avoid copying the ~104KB payload (fixes throughput regression) - WAL files are purged on clean shutdown after buffer flush, preventing duplicate recovery on restart - Fixed _database/_measurement key mismatch in row-based WAL recovery
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x01marker + db name length + db name), enabling correct database routing on recoveryAppendRawWithMetabuilds WAL entries in a single allocation (was copying ~104KB payload per entry, causing throughput to drop from 4.6M to 400K logs/sec)_database/_measurementkey mismatch in row-based WAL recovery callbackTest plan
go build ./cmd/... ./internal/...compilesgo test ./internal/wal/...passes