perf: Add fast-path checks to time function rewrites#99
Merged
Conversation
Add early-exit checks to rewriteTimeBucket() and rewriteDateTrunc() to skip expensive regex operations when the SQL doesn't contain the target function names. Before this change, ReplaceAllStringFunc was called on every query even when no patterns matched, causing unnecessary allocations: - time_bucket patterns: 16 allocs, 41KB per query - date_trunc pattern: 5 allocs, 2.3KB per query With fast-path checks using strings.Contains: - Queries without time functions: ~15-19% faster - Eliminates ~44KB of allocations per query - Zero impact on queries that DO use time functions Benchmark results (ns/op): - simple_select: 15,824 → 13,424 (-15%) - complex_query: 46,971 → 38,142 (-19%)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add early-exit checks to rewriteTimeBucket() and rewriteDateTrunc() to skip expensive regex operations when the SQL doesn't contain the target function names.
Before this change, ReplaceAllStringFunc was called on every query even when no patterns matched, causing unnecessary allocations:
With fast-path checks using strings.Contains:
Benchmark results (ns/op):