fix(decode): cap alloc limits and fix flag check for OOM safety#34
Merged
fix(decode): cap alloc limits and fix flag check for OOM safety#34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decodeSlice()allocation atsliceAllocLimit(1M) to prevent OOM from malicious payloads claiming huge array lengthsDecodeMap()allocation atmaxMapSize(1M) — same OOM vector for themap[string]interface{}path used by Arc's*interface{}fast pathdisableAllocLimitFlagcheck indecodeSliceValue—!= 1was always true because the flag value is1 << 3 = 8, sogrowSliceValue()alloc limit was never appliedDecodeFloat64— said "decoding float32" instead of "decoding float64"Closes #1, closes #13.
Test plan
go test ./... -v -count=1— all tests pass (except pre-existing upstream TestTypes panic, issue Decode panics on nil interface with pre-populated typed pointer (upstream #304) #21)go test -run='^$' -bench=. -benchmem -count=3— zero performance regression