fix(encode): respect non-zero unexported fields in omitempty check (#6)#43
Merged
fix(encode): respect non-zero unexported fields in omitempty check (#6)#43
Conversation
The omitempty emptiness check only examined exported fields, causing structs with non-zero unexported data to be incorrectly omitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omitemptyincorrectly omits structs with non-zero unexported fieldsisEmptyValuebefore evaluating exported fieldsomitemptyunexpectedly omits a member when the member is a struct with a non-zero unexported member vmihailenco/msgpack#378Test plan
TestOmitEmptyUnexportedFieldsvalidates structs with non-zero unexported fields are NOT omitted