Skip to content

Lint files#2383

Merged
seefood merged 1 commit intoBash-it:masterfrom
BarbUk:master
Apr 18, 2026
Merged

Lint files#2383
seefood merged 1 commit intoBash-it:masterfrom
BarbUk:master

Conversation

@BarbUk
Copy link
Copy Markdown
Contributor

@BarbUk BarbUk commented Apr 18, 2026

Lint files

Description

#2378 fixed a previous shfmt lint issue.

But a new commit has reverted this change:
mvdan/sh@d2b044b

This PR will rollback #2378 changes to fix the pre-commit / CI linting.

How Has This Been Tested?

❯ ./lint_clean_files.sh
trim trailing whitespace....................................................Passed
fix end of files............................................................Passed
check for merge conflicts...................................................Passed
mixed line ending...........................................................Passed
check for added large files.................................................Passed
Check for conflict markers and core.whitespace errors.......................Passed
Test shell scripts with shellcheck..........................................Passed
Check shell style with shfmt................................................Passed
CRLF end-lines remover......................................................Passed
Check .sh files against bash-it requirements................................Passed
Check .bash files against bash-it requirements..............................Passed
Check that clean_files.txt is sorted alphabetically.........................Passed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@seefood seefood merged commit 69c4dcb into Bash-it:master Apr 18, 2026
6 checks passed
@seefood
Copy link
Copy Markdown
Contributor

seefood commented Apr 18, 2026

Weird thing is, I think the fixes it wanted used to be the other way around once. I guess they changed the rules...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants