issue 357 fixed preview button blocking #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PranathiChillarige
force-pushed
the
fix/blocking-of-preview-button-in-json-generator
branch
from
b67d22c to
a4ff0e9
Compare
annuk123
approved these changes
Oct 6, 2024
Contributor
Author
|
Hey @Bashamega Can we close this issue now? |
Collaborator
Nope |
Owner
I have closed it |
Collaborator
okay, Actually there is an issue, that's why I told |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - #357
Description -
This PR aims to avoid the blocking of Action buttons(preview button, Export button and rows input field)
with underneath content(add another field button) in mobile and desktop view by
1 . creating a scrollable section for fields.
2 . adjusting the margins/bottom in between to update the page layout properly.
3 . modifying
initialFieldsto 3 as it has a scrollable section and also to avoid clumsiness on the page layout.4 . hidden Field header(Field name, Field type) when there are no fields as these headings are not required to be shown when there are no fields.
Screenshots -
Please feel free to suggest any changes, will update accordingly. Thank you.