Skip to content

Conversation

@dax4y
Copy link
Contributor

@dax4y dax4y commented Oct 9, 2024

Description

  • fixing FEATURE issue [FEATURE] Filter Github Issues by label #319

  • added option for adding new Labels in ghFilter

  • improved filtering by clicking on Labels (add/remove)

  • Labels which are already used in filter will appear in the TOP of the page

  • implemented Labels in URL - when someone will refresh page, selected labels in filter won't be lost

  • implemented tests for this components

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable):

Snímka obrazovky 2024-10-09 o 12 56 01

@dax4y dax4y requested a review from Bashamega as a code owner October 9, 2024 10:57
@vercel
Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-dev-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 3:59pm

Copy link
Owner

@Bashamega Bashamega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the selected labels add an x button beside it so users can remove it

@dax4y
Copy link
Contributor Author

dax4y commented Oct 9, 2024

for the selected labels add an x button beside it so users can remove it

you mean ... for the selected Labels highlighted on the top ?

@Bashamega
Copy link
Owner

for the selected labels add an x button beside it so users can remove it

you mean ... for the selected Labels highlighted on the top ?

Yes

@dax4y
Copy link
Contributor Author

dax4y commented Oct 9, 2024

for the selected labels add an x button beside it so users can remove it

you mean ... for the selected Labels highlighted on the top ?

Yes

done

@Bashamega
Copy link
Owner

for the selected labels add an x button beside it so users can remove it

you mean ... for the selected Labels highlighted on the top ?

Yes

done

If there is an extra label that is not in the list and it is check please add it
image

@dax4y
Copy link
Contributor Author

dax4y commented Oct 9, 2024

done

Copy link
Owner

@Bashamega Bashamega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@Bashamega Bashamega merged commit 29f531f into Bashamega:main Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants