-
-
Notifications
You must be signed in to change notification settings - Fork 95
More robust validation of avatar texture settings #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More robust validation of avatar texture settings #484
Conversation
|
In my opinion, needs to be a more advanced check due to some people will forget to enable mipmaping for their avatar textures. And if you enable the streaming even though mipmap is off will pass the check currently and wont affect the texture since its off. So might force enable streaming textures for all textures will be better. |
|
Mip maps are enabled by default; if they are disabled that means the person who imported them specifically turned them off. |
|
i think we need todo more to identify ignorable textures instead of just not warning, luts tend to be small and toys made a good point that really small textures could just be skipped to solve most of the issues at hand |
|
mipmap streaming is one of the only things we have to reduce the memory footprint of avatars / uploaded content. |
|
But the check does not validate or enforce 'Generate Mipmap'. Only 'Stream Mipmap Levels', which does nothing if 'Generate Mipmap' is off. |
|
ok i see, yes that could be improved |
|
The fix you have is a Band-Aid and will lead to missed opportunities for performance gains from streaming. we need to improve this further.
|
af3f740 to
145503b
Compare
|
I made the checks more robust:
I also noticed some issues with the auto-fix buttons (they were gray before the first hover and the text overflowed) so I fixed those and added a warning color and optional action title; let me know if that would be better resolved another way. |
|
Appreciated |

No description provided.