Skip to content

Fix bounds calculation for skinned meshes #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
art0007i wants to merge 1 commit into
base: developer
Choose a base branch
from
Open

Fix bounds calculation for skinned meshes #780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions Basis/Packages/com.basis.sdk/Scripts/Editor/SDKInspector/BasisBundleBuild.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,32 +66,30 @@ public static Bounds CalculateLocalRenderBounds(GameObject parent)
{
if (r == null) continue;

Bounds srcLocal;
Bounds transformed;

if (r is SkinnedMeshRenderer smr)
{
// In smr local space
srcLocal = smr.localBounds;
// Transform bounds center and extents to new AABB in parent local space
transformed = TransformBoundsAABB(smr.bounds, parentWorldToLocal);
}
else if (r is MeshRenderer mr)
{
var mf = mr.GetComponent<MeshFilter>();
if (mf == null || mf.sharedMesh == null) continue;

// In mesh local space (same as MeshFilter transform local space)
srcLocal = mf.sharedMesh.bounds;
var srcLocal = mf.sharedMesh.bounds;
// Map from renderer local -> world -> parent local
Matrix4x4 toParentLocal = parentWorldToLocal * r.transform.localToWorldMatrix;
// Transform bounds center and extents to new AABB in parent local space
transformed = TransformBoundsAABB(srcLocal, toParentLocal);
}
else
{
continue; // ignore other renderer types for now
}

// Map from renderer local -> world -> parent local
Matrix4x4 toParentLocal = parentWorldToLocal * r.transform.localToWorldMatrix;

// Transform bounds center and extents to new AABB in parent local space
Bounds transformed = TransformBoundsAABB(srcLocal, toParentLocal);

if (!hasAny)
{
accum = transformed;
Expand Down