feat: Always give the present 10% of the distribution history's width by BayerC · Pull Request #142 · BayerC/open_cups

BayerC · 2026-02-26T06:46:09Z

Closes #65
Closes #141

BayerC · 2026-02-26T06:47:37Z

@cbachhuber just an idea how to solve that we always have 10% for the current data

codecov · 2026-02-26T06:48:11Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (cb5f9f3) to head (52bcefd).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #142   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          490       502   +12     
=========================================
+ Hits           490       502   +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cbachhuber · 2026-02-26T20:35:49Z

This isn't a bad idea at all! It also doesn't suffer from the complications of my approaches. Should we go with this?

This reverts commit 60ce7c9.

cbachhuber · 2026-02-28T05:34:15Z

+    timestamps = [
+        (snapshot.timestamp - latest_snapshot_time) / 60 for snapshot in status_history
+    ]
+
+    timestamps_extended = add_future_timestamp(timestamps, relative_extension=0.1)
+
+    data = {"Time (minutes)": timestamps_extended}
    for user_status in UserStatus:
+        counts = [snapshot.counts[user_status] for snapshot in status_history]
        data[user_status.value] = [
-            snapshot.counts[user_status] for snapshot in status_history
-        ]
+            *counts,
+            counts[-1],
+        ]  # repeat last value in future timestamp


I considered extracting all of this to a function that creates data. However, later in this function, we still need timestamps_extended, so I didn't extract that.

We could extract a function that computes data and also returns the time range. What do you think about that?

I think its fine

cbachhuber · 2026-02-28T05:35:32Z

@BayerC thanks again for the idea, you saved my sanity!

I've updated this PR, it's now ready to go in after #144 :)

cbachhuber · 2026-02-28T05:37:33Z

Also note 60ce7c9: I temporarily added the ability to speed up time via an env var for my experiments (sample usage: TIME_SCALE=20.0 uv run streamlit run main.py). This doesn't affect sampling frequency because of streamlit's limits, unfortunately. If affects everything else though and was thus very useful for my experiments.

Do you think we should keep that, @BayerC?

cbachhuber · 2026-03-04T05:20:34Z

@BayerC since the majority of changes now comes from me, can you review this PR and merge if you're happy?

cbachhuber

LGTM, approving to make this mergeable after @BayerC's review

BayerC · 2026-03-05T18:45:28Z

@sourcery-ai review

sourcery-ai

Hey - I've left some high level feedback:

Consider handling or explicitly guarding against an empty status_history in show_status_history_chart / add_future_timestamp, since both currently assume at least one timestamp and will fail with timestamps[-1] or counts[-1] otherwise.
The relative_extension=0.1 magic value is now part of the chart semantics; it may be clearer to promote this to a named constant (similar to MAX_NUMBER_OF_TICKS) so the 10% extension behavior is easier to discover and tweak.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider handling or explicitly guarding against an empty `status_history` in `show_status_history_chart` / `add_future_timestamp`, since both currently assume at least one timestamp and will fail with `timestamps[-1]` or `counts[-1]` otherwise.
- The `relative_extension=0.1` magic value is now part of the chart semantics; it may be clearer to promote this to a named constant (similar to `MAX_NUMBER_OF_TICKS`) so the 10% extension behavior is easier to discover and tweak.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

BayerC · 2026-03-05T18:48:58Z

I dont see any time on the x-axis anympore is this intendet @cbachhuber

BayerC · 2026-03-05T18:50:36Z

 )
 from open_cups.types import UserStatus

+MAX_NUMBER_OF_TICKS = 10


shouldnt move this more closered (1 line above) where it is used?
Its very specific to the function

Right, my thinking was to put the 'config' to the top of the file. Similar as with the color values.

I'm absolutely open to moving this inside the function, if you prefer.

I would prefer having it in the function since a more a named magic number than a config

you could do in follow up, get this merged!

cbachhuber · 2026-03-06T16:13:59Z

@BayerC wrote

I dont see any time on the x-axis anympore is this intendet @cbachhuber

In your screenshot, you actually see -1 and 0. Give it some more time for the integers to appear. We don't do sub-integer times on the x-axis, never have. Is this acceptable?

BayerC · 2026-03-06T16:45:25Z

@BayerC wrote

I dont see any time on the x-axis anympore is this intendet @cbachhuber

In your screenshot, you actually see -1 and 0. Give it some more time for the integers to appear. We don't do sub-integer times on the x-axis, never have. Is this acceptable?

its fine i waited not long enough

poc: fixed current area

9d0204f

BayerC requested a review from cbachhuber February 26, 2026 06:46

Chris Bachhuber added 4 commits February 28, 2026 05:57

Limit maximum number of ticks

4512d7a

Add ability to fake time

60ce7c9

Revert "Add ability to fake time"

73f78d3

This reverts commit 60ce7c9.

Extract function

15dd1a4

cbachhuber mentioned this pull request Feb 28, 2026

chore: no more status bar display in host view #144

Merged

cbachhuber changed the title ~~poc: fixed current area~~ feat: Always give present 10% of the width in distribution history Feb 28, 2026

cbachhuber reviewed Feb 28, 2026

View reviewed changes

Reset to main

c7e8c8f

cbachhuber and others added 3 commits March 4, 2026 06:14

Merge branch 'main' into poc/fixed-current-area

7838ae9

Fix format

c4d98c0

Merge branch 'main' into poc/fixed-current-area

52bcefd

cbachhuber marked this pull request as ready for review March 4, 2026 05:18

cbachhuber enabled auto-merge (squash) March 4, 2026 05:18

cbachhuber disabled auto-merge March 4, 2026 05:20

cbachhuber approved these changes Mar 4, 2026

View reviewed changes

cbachhuber changed the title ~~feat: Always give present 10% of the width in distribution history~~ feat: Always give the present 10% of the width in distribution history Mar 4, 2026

cbachhuber changed the title ~~feat: Always give the present 10% of the width in distribution history~~ feat: Always give the present 10% of the distribution history's width Mar 4, 2026

sourcery-ai bot reviewed Mar 5, 2026

View reviewed changes

BayerC commented Mar 5, 2026

View reviewed changes

BayerC merged commit 0e37961 into main Mar 6, 2026
13 checks passed

Uh oh!

Conversation

BayerC commented Feb 26, 2026 • edited by cbachhuber Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BayerC commented Feb 26, 2026

Uh oh!

codecov bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cbachhuber commented Feb 26, 2026

Uh oh!

cbachhuber Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

BayerC Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

cbachhuber commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cbachhuber commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cbachhuber commented Mar 4, 2026

Uh oh!

cbachhuber left a comment

Choose a reason for hiding this comment

Uh oh!

BayerC commented Mar 5, 2026

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

BayerC commented Mar 5, 2026

Uh oh!

BayerC Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

cbachhuber Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

BayerC Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

BayerC Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

cbachhuber commented Mar 6, 2026

Uh oh!

Uh oh!

BayerC commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BayerC commented Feb 26, 2026 •

edited by cbachhuber

Loading

codecov bot commented Feb 26, 2026 •

edited

Loading

cbachhuber commented Feb 28, 2026 •

edited

Loading

cbachhuber commented Feb 28, 2026 •

edited

Loading