Skip to content

Question about the implementaion for Long Crash Tube Task #13

@KeiHiroshima

Description

@KeiHiroshima

Thank you for your great work.
I have a question about the implementaion for Long crash tube task. In your paper, the triplet is defined in "zi, εi, hi" order and domain as below:

Each trigger is characterized by a triplet (zi, εi, hi ), where zi denotes the axial (along the z-axis) position of the trigger’s centroid relative to a fixed reference point, εi represents the trigger’s protrusion (depth) from the face surface, and hi corresponds to its vertical extent (height).
−40 mm ≤ zi ≤ 40 mm, −4 mm ≤ εi ≤ 4 mm, 0 mm ≤ hi ≤ 16 mm.

However it seems those are defined as "εi, zi, hi" and each of those ranges as following in your code:

patterns = [(-4, 4), (-10, 10), (0, 4)]

@staticmethod
def _generate_variable_ranges_map(dimension:int)->List[tuple]:
r"""
Generates the ranges map given a dimensionality; This is a
static method, which is provided with the class to call methods
outsude the framework.
Args
----------------------
- dimension: `int`: An integer denoting the dimensionality set by the user
Returns
----------------------
- `List[tuple]`: A list of tuples indicating the physical ranges of the problem.
"""
patterns = [(-4, 4), (-10, 10), (0, 4)]
variable_ranges_map = {}
for dim in range(1, dimension+1):
variable_ranges_map[dim] = [patterns[i % 3] for i in range(dim)]
return variable_ranges_map[dimension]

That would be appreciated if you would check your implementation and reply. Thank you.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions