code refactoring and fixing pylint #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
asa1997
reviewed
Apr 25, 2023
Contributor
asa1997
left a comment
asa1997
left a comment
There was a problem hiding this comment.
@sudhirverma Is the file name change required?
Contributor
Author
Yes those are pylint error/warning. |
Contributor
|
@sudhirverma The code for writing version details is appending the data eventhough the version is already present. It should say that version is already present. |
asa1997
requested changes
Apr 26, 2023
Contributor
asa1997
left a comment
asa1997
left a comment
There was a problem hiding this comment.
@sudhirverma Please address the comment
Contributor
Author
@asa1997 can you check again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.