-
Notifications
You must be signed in to change notification settings - Fork 18
Add WebP support and update dependencies #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
f57f759
db240d6
50732ce
56120c3
d8070be
803eb39
17492e8
8ad12c8
90876fc
0a61e3b
fc805ae
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ const loaders = require('./loaders') | |
| const mode = 'development' | ||
|
|
||
| module.exports = merge(common, { | ||
| mode: mode, | ||
| mode, | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @firestar300 toujours ok cette modif ? au vu des derniers ajustements |
||
| stats: 'errors-only', | ||
| devtool: 'inline-source-map', | ||
| devServer: { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ const loaders = require('./loaders') | |
| const mode = 'production' | ||
|
|
||
| module.exports = merge(common, { | ||
| mode: mode, | ||
| mode, | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ici aussi |
||
| stats: 'minimal', | ||
| output: { | ||
| filename: '[name]-min.js', | ||
|
|
||
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SVGO config wrapped in extra object layer
Medium Severity
The
svgoconfigvariable (which exports{ plugins: [...] }) is passed as{ svgoconfig }, creating the object{ svgoconfig: { plugins: [...] } }due to ES6 shorthand property syntax. Theimagemin-svgoplugin expects the config object directly (e.g.{ plugins: [...] }), so the custom SVGO settings are silently ignored and defaults are used instead. The correct usage is['svgo', svgoconfig]without the wrapping braces.Reviewed by Cursor Bugbot for commit fc805ae. Configure here.