feat (theme) : get minified editor-style if production env #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Rahe poke :) |
Rahe
reviewed
Nov 20, 2019
inc/services/theme.php
Outdated
| $file = 'editor-style.css'; | ||
|
|
||
| if ( ! defined( 'SCRIPT_DEBUG' ) || SCRIPT_DEBUG === false ) { | ||
| $file = Framework::get_container()->get_service('assets')->get_min_file( 'editor-style.css' ); |
Member
There was a problem hiding this comment.
Marchera pas si on modifie pas de le get_min_file pour gérer le cas "editor-style".
Member
There was a problem hiding this comment.
Il faut impacter la fonction get_min_file aussi :)
Contributor
Author
There was a problem hiding this comment.
Ah oui bien vu, un oubli ^^
Contributor
Author
|
@Rahe Fixed, good pour toi ? |
Member
|
Faut que je teste la PR ^^ |
Member
|
J'ai corrigé/ajusté les fonctions utilisées :) |
Contributor
Author
|
Vu, merci. Je merge ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.