Skip to content

feat (theme) : get minified editor-style if production env #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 4, 2019
Merged

feat (theme) : get minified editor-style if production env #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1883015
feat (theme) : get minified editor-style if production env
firestar300 Nov 5, 2019
32bc8a6
feat : add case editor-style in get_min_file function
firestar300 Dec 2, 2019
22ef6ee
Use a slug for the style name
Rahe Dec 3, 2019
8225cca
Change for the file slug, use yoda condition
Rahe Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions inc/services/assets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,9 @@ public function get_min_file( $type ) {
case 'css':
$file = $assets['app.css'];
break;
case 'editor-style':
$file = $assets['editor-style.css'];
break;
case 'js':
$file = $assets['app.js'];
break;
Expand Down
19 changes: 18 additions & 1 deletion inc/services/theme.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<?php

namespace BEA\Theme\Framework\Services;
use BEA\Theme\Framework\Framework;
use BEA\Theme\Framework\Service;
use BEA\Theme\Framework\Service_Container;

Expand Down Expand Up @@ -71,6 +72,22 @@ private function i18n() {
* editor style
*/
private function editor_style() {
add_editor_style('dist/assets/editor-style.css');
/**
* Default file
**/
$file = 'editor-style.css';

if ( ! defined( 'SCRIPT_DEBUG' ) || false === SCRIPT_DEBUG ) {
$file = Framework::get_container()->get_service( 'assets' )->get_min_file( 'editor-style' );
}

/**
* Do not enqueue a inexistant file on admin
*/
if ( ! is_file( get_theme_file_path( 'dist/assets/' . $file ) ) ) {
return;
}

add_editor_style( 'dist/assets/' . $file );
}
}