Skip to content

add setting to set close button label#24

Merged
MarieComet merged 3 commits intodevelopfrom
add-close-button-label-setting
Apr 10, 2026
Merged

add setting to set close button label#24
MarieComet merged 3 commits intodevelopfrom
add-close-button-label-setting

Conversation

@MarieComet
Copy link
Copy Markdown
Contributor

@MarieComet MarieComet commented Apr 9, 2026

#12

Capture d’écran 2026-04-09 à 14 46 32

Note

Low Risk
Low risk: adds an optional block attribute and editor control to override close button text, with straightforward serialization changes and updated translation files.

Overview
Adds a new closeButtonLabel block attribute and an inspector TextControl so editors can override the modal close button text when the close button is enabled.

Updates both editor preview and saved markup to render the custom label (falling back to the default Close this dialog window string), and refreshes i18n catalogs (.pot, fr_FR files) plus bumps package/version metadata to 1.0.6.

Reviewed by Cursor Bugbot for commit 43dc970. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8248c8b. Configure here.

@MarieComet MarieComet merged commit 01491ad into develop Apr 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants