AUE-23: When key doesn't exist, prohibits reject rules specifying ver…#35
Merged
OferMania merged 1 commit intoBeStateless:masterfrom Jun 14, 2021
Merged
AUE-23: When key doesn't exist, prohibits reject rules specifying ver…#35OferMania merged 1 commit intoBeStateless:masterfrom
OferMania merged 1 commit intoBeStateless:masterfrom
Conversation
…sionNE or versionLE
- This breaks changesets for nfapp, since using any old version to update
a key incorrectly resurrects it from the dead, undoing the hard work
of the nfapp table cleaner
- Also adds ability to output logs for RAMCloud test cluster, great for debugging
adickson66
approved these changes
Jun 11, 2021
| for table_name in table_names: | ||
| r.drop_table(table_name) | ||
|
|
||
| def output_logs_detached(docker_containers, path="/src/tmp"): |
Contributor
There was a problem hiding this comment.
what does "detached" mean here?
Contributor
Author
There was a problem hiding this comment.
We are not attached to a ClusterTestUtil object that brings up the test cluster from scratch, instead, we're detached from that cluster, but still trying to connect to it to get logs.
dennisafa
approved these changes
Jun 11, 2021
james-munson
approved these changes
Jun 14, 2021
Contributor
james-munson
left a comment
james-munson
left a comment
There was a problem hiding this comment.
Just one minor suggestion on the test scaffold. Patch looks good.
| parser.add_argument('--nodes', '-n', type=int, default=3, | ||
| help="Number of zk, rc-coordinator, and rc-server instances to bring up. Only relevant when there's no cluster up yet. Default is 3") | ||
| parser.add_argument('--path', '-p', type=str, default="/src/tmp", | ||
| help="Path to place logs in when action is set to \"log\"") |
Contributor
There was a problem hiding this comment.
Perhaps it would be clearer to name the option and the variable "log_path".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sionNE or versionLE
This breaks changesets for nfapp, since using any old version to update
a key incorrectly resurrects it from the dead, undoing the hard work
of the nfapp table cleaner
Also adds ability to output logs for RAMCloud test cluster, great for debugging