Skip to content

fix: rename luminarr to prism in Dockerfile and Dockerfile.minimal#3

Merged
davidfic merged 2 commits intomainfrom
fix/dockerfile-rename-luminarr-to-prism
Apr 16, 2026
Merged

fix: rename luminarr to prism in Dockerfile and Dockerfile.minimal#3
davidfic merged 2 commits intomainfrom
fix/dockerfile-rename-luminarr-to-prism

Conversation

@davidfic
Copy link
Copy Markdown
Contributor

Summary

Both docker files were inherited byte-for-byte from the original luminarr fork and still referenced `luminarr` throughout — Go module ldflag paths, the output binary name, the `cmd/` target, the non-root user in the scratch image, and the ENTRYPOINT.

CI didn't catch this until now because the docker job gates on `github.event_name == 'push' && ref == refs/heads/main` — so the docker build only fires on merges to main, not on PR builds. The moment the earlier subtree PR merged and triggered the main CI run, the docker job failed with:

```
go build -o /luminarr ./cmd/luminarr
no Go files in ./cmd/luminarr
```

Test plan

  • CI main green on next push (once this PR merges)
  • `latest` image publishes to `ghcr.io/beacon-stack/prism`
  • `latest-minimal` image publishes

davidfic and others added 2 commits April 15, 2026 20:21
Both Dockerfiles were inherited byte-for-byte from the original
luminarr fork and still referenced luminarr throughout — the Go
module ldflag paths, the output binary name, the cmd target, the
non-root user in the scratch image, and the ENTRYPOINT. They
compiled on luminarr because that repo's go.mod said
github.com/luminarr/luminarr, but on prism the go build step
immediately fails with "no Go files in ./cmd/luminarr".

CI only surfaced this now because the docker job only fires on
main-branch pushes (if: github.event_name == 'push' && ref ==
refs/heads/main), so the failure was hidden during every PR run and
only appeared the moment the merge to main triggered the release path.

Three places in Dockerfile.minimal also wrote /etc/passwd.luminarr
and /etc/group.luminarr for the scratch-image non-root user — those
filenames don't affect runtime but were renamed for consistency.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Same issue pilot just hit. The Build and push (minimal) step in
ci.yml was using ghcr.io/\${{ github.repository }}:latest-minimal,
which preserves the org casing and produces the invalid tag
ghcr.io/Beacon-Stack/prism:latest-minimal — GHCR strictly requires
lowercase image names. The sibling latest step escapes this by
using docker/metadata-action outputs which auto-lowercase; the
minimal step hardcodes the tag directly and misses that treatment.

Spell the repo explicitly as ghcr.io/beacon-stack/prism.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@davidfic davidfic merged commit 0953dd2 into main Apr 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant