chore(clippy): apply pedantic auto-fixes (inline format args + method refs)#134
Merged
Conversation
… refs)
Mechanical \`cargo clippy --fix\` cleanup with three pedantic lints:
- \`clippy::uninlined_format_args\` — \`format!(\"{}\", x)\` → \`format!(\"{x}\")\`
- \`clippy::redundant_closure_for_method_calls\` — \`.map(|x| x.to_string())\` → \`.map(ToString::to_string)\`
- \`clippy::needless_raw_string_hashes\` — drop \`#\` when not needed
27 files touched, all single-line substitutions. No logic changes,
no behavior changes. Verified:
- \`cargo check --workspace\` clean
- \`cargo fmt --all --check\` clean
- \`cargo clippy --workspace --all-features --all-targets -- -D warnings\` clean (existing CI standard)
- ck-engine tests pass (\`--no-default-features\` to skip local ort link issue)
No \`#![warn(clippy::pedantic)]\` added — we keep the default warn
level as the CI gate. This is one-time noise reduction so future
file-level edits don't get incidental fmt drift.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
runonthespot
added a commit
that referenced
this pull request
May 24, 2026
Ships #133 (security: 11 CodeQL alerts + 4 npm transitives closed) and #134 (clippy pedantic auto-fix cleanup across 27 files). After this release: open security alerts = 0 across both Dependabot and CodeQL surfaces. Cutting partly so the in-flight community PRs (#102 C/C++ support, #104 markdown support) have a clean current base to rebase on. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mechanical `cargo clippy --fix` cleanup with three pedantic lints, opt-in just for this pass:
27 files touched, all single-line substitutions. No logic changes, no behavior changes.
Why now
Reduces incidental fmt drift on future PRs (most files would otherwise gain one or two inlined-format-arg changes whenever someone touches them). One-time cleanup so the diff is concentrated rather than scattered.
What I did NOT do
Verified
🤖 Generated with Claude Code