Support gettext ~> 1.0 for Phoenix 1.8 compatibility#860
Open
bmalum wants to merge 2 commits intoBeaconCMS:mainfrom
Open
Support gettext ~> 1.0 for Phoenix 1.8 compatibility#860bmalum wants to merge 2 commits intoBeaconCMS:mainfrom
bmalum wants to merge 2 commits intoBeaconCMS:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Beacon installable and functional on Phoenix 1.8.
Changes
Widen gettext dependency (
mix.exs)~> 0.26→~> 0.26 or ~> 1.0Phoenix 1.8 ships with
{:gettext, "~> 1.0"}, causing a Hex resolution failure. The codebase already uses the gettext 1.0-compatible API (Gettext.Backend,backend:option, directGettext.dgettext/4calls), so onlythe version constraint needed updating.
Replace removed private API (
lib/beacon/private.ex)Phoenix.Endpoint.Supervisor.config/2was removed in Phoenix 1.8, breakingBeacon.Private.endpoint_host/2at runtime:Replaced with
endpoint.host/0, which is the public callback available on all Phoenix endpoints.Closes #859