Fix remaining review issues from PR #335 and #338#339
Merged
ddon merged 2 commits intoBeamLabEU:devfrom Feb 15, 2026
Merged
Conversation
- Add admin auth checks for single-record handlers in data_navigator - Move require Logger to module level in shop.ex - Filter only active products in category featured product dropdown - Add recursive circular reference validation for category parents - Prevent ancestor cycles in bulk category parent update - Split load_categories into static data cache and filtered query - Remove unused noop event handler and phx-click attributes - Remove unused MIM demo images (8.2MB)
ddon
pushed a commit
that referenced
this pull request
Feb 15, 2026
Add visited-node tracking to check_ancestor_cycle to prevent infinite loops when the database contains a pre-existing cycle. Add PR #339 review documents. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ddon
pushed a commit
that referenced
this pull request
Feb 15, 2026
- Add Kimi review: approve with all 7 issues resolved - Add Mistral review: approve with critical bug fixed Both reviews confirm PR #339 is production-ready. Co-Authored-By: Kimi <noreply@moonshot.cn> Co-Authored-By: Mistral <noreply@mistral.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all 7 remaining issues identified by Claude, Mistral, and Kimi reviews of PR #338.
Changes
Security
Scope.admin?authorization checks for single-record handlers (archive_data,restore_data,toggle_status) in Data NavigatorBug Fixes
bulk_update_category_parentPerformance
load_categoriesintoload_static_category_data+load_filtered_categories— static data (all_categories, product_counts) only reloaded on mount and mutations, not on every filter/search/page changeCode Quality
require Loggerto module level inshop.exnoopevent handler andphx-click="noop"attributes from categories templateRepo Hygiene
Test Plan
mix compile— clean, no warningsmix format— formattedmix credo --strict— no issuesmix dialyzer— passes (285 skipped, 0 new)