Wrap /admin/modules page strings in gettext + ru/et translations#530
Merged
Merged
Conversation
Wrap all user-facing strings in modules.html.heex with gettext() calls (~80 wrapping sites across 51 unique msgids). Extract msgids via mix gettext.extract --merge and fill Russian and Estonian msgstrs. Other locales (de/es/fr/it/pl) receive empty msgstrs and fall back to English msgid. Shared msgids also filled: Configure, Settings, Connections, Maintenance Mode, Published (were empty, used by modules page too).
timujinne
added a commit
to timujinne/phoenix_kit
that referenced
this pull request
May 11, 2026
Resolved conflicts in priv/gettext/{et,ru}/LC_MESSAGES/default.po by taking
upstream/dev side. Rationale:
et:
- Sessions: Sessioonid (consistent with "Aktiivsed sessioonid")
- Settings: Seaded (consistent with rest of file)
- Health: Seisund (more semantic)
- Big block: upstream's gettext.extract already covered all admin_tabs.ex
msgids from PRs BeamLabEU#530/BeamLabEU#531 with matching translations; the orphan "Home"
entry added in this branch had no source reference (admin_dashboard
label is "Dashboard", not "Home") and was dropped.
ru:
- Permissions: Права (consistent with "Права для", "Права обновлены")
- Big block: same reasoning as et.
PR's gettext_backend wiring in admin_tabs.ex (8 tabs), registry.ex (2
tabs), and jobs.ex (1 tab) preserved by the merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modules.html.heex(~80 call sites, 51 unique msgids) withgettext()callsmix gettext.extract --mergeto populatedefault.potand all locale.pofilesru) and Estonian (et) msgstrs for all new msgidsConfigure,Settings,Connections,Maintenance Mode,Publishedmsgstr ""and fall back to EnglishRelated: #522, #527, #529
Strings wrapped
Headings, subtitles, button labels, badge text, stat labels, empty-state hints, help text — covering all 10 built-in module cards (Storage, Referral Codes, Languages, Comments, Customer Support, Connections, SEO, Sitemap, Maintenance Mode, Jobs) plus the external modules loop and Available Packages section.
Verification
Verified live on
decor_3d_print(port 4001) via Tidewave MCPproject_eval:Test plan
mix compilecleanmix format --check-formattedpassesmix credo --strict— no issuesmix dialyzerpasses@versionbump, no CHANGELOG.md edit