Wire Etcher 0.6.5 into the Media viewer#584
Merged
Merged
Conversation
…arker
Upgrade etcher 0.5.5 -> 0.6.5 and wire its new capabilities into
MediaCanvasViewer (the shared Fresco+Etcher component behind MediaBrowser,
MediaDetail and the lightbox).
- Per-user line params ("ink"): the global stroke defaults (width / opacity
/ dash) save to custom_fields["etcher_line_params"] via the new
etcher:line-params-changed hook, one set per user across every viewer —
mirroring the color palette. Sanitized on read and write (width 1..40,
opacity 0..1, dash enum, merged over the default).
- Expose the full 0.6.5 toolset: add :grabber (pan) and :marker
(highlighter), previously omitted from the tools list.
- Marker is pure marking for now — it persists like any shape (via
annotations-changed) but skips the annotation composer, so highlighting
doesn't prompt for a title/comment. Its tooltip shows a byline instead:
the drawing user's display name (stamped into metadata server-side at
creation, not the spoofable client wire) over the creation date — filled
instantly via patch-shape and identical after reload.
- Fix marker persistence: V129 migration widens
phoenix_kit_annotations_kind_check to allow 'marker', and Annotation's
@kinds adds it. Without both layers the insert was rejected and silently
dropped, so a marker vanished on reload. Covered by a new test asserting
both the changeset and the DB constraint accept marker.
Also bump the jsDelivr CDN pin in phoenix_kit.js (@v0.5.5 -> @v0.6.5) for
vendored/CDN consumers, and bump credo 1.7.18 -> 1.7.19 and owl
0.13.0 -> 0.13.1.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
# Conflicts: # lib/phoenix_kit/migrations/postgres.ex # lib/phoenix_kit/migrations/postgres/v129.ex
ddon
pushed a commit
that referenced
this pull request
Jun 5, 2026
The Etcher 0.6.5 line-params/marker work is alexdont's PR #584, so file the review at 584-etcher-0.6.5-media-viewer/CLAUDE_REVIEW.md (next to his #581 colors review) instead of a number-less slug — keeps Alex's Etcher reviews grouped and findable by PR. Header updated to reference #584. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…arker
Upgrade etcher 0.5.5 -> 0.6.5 and wire its new capabilities into MediaCanvasViewer (the shared Fresco+Etcher component behind MediaBrowser, MediaDetail and the lightbox).