Skip to content

Fix hex dep, add CSS scanning, update to daisyUI 5 components#3

Merged
ddon merged 5 commits into
BeamLabEU:mainfrom
mdon:main
Apr 2, 2026
Merged

Fix hex dep, add CSS scanning, update to daisyUI 5 components#3
ddon merged 5 commits into
BeamLabEU:mainfrom
mdon:main

Conversation

@mdon
Copy link
Copy Markdown
Contributor

@mdon mdon commented Apr 2, 2026

Summary

  • Fix phoenix_kit dependency — switch from local path: to hex {:phoenix_kit, "~> 1.7"} (was accidentally left as local during development)
  • Add css_sources/0 — enables automatic Tailwind CSS scanning via the new :phoenix_kit_css_sources compiler
  • Remove local status_badge components — history.ex and connections_live.ex had local implementations that now conflict with core's unified status_badge/1 (which covers all sync
    statuses)
  • daisyUI 5 compatibility — remove deprecated select-bordered class and migrate all elements to the new wrapper pattern, fixing selects rendering incorrectly during LiveView navigation

mdon and others added 5 commits April 2, 2026 08:09
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The core status_badge now handles all statuses including sync-specific
ones (completed, failed, in_progress, denied, etc).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
daisyUI 5 applies borders by default on select elements, making
select-bordered obsolete.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
daisyUI 5 changed the select component to use a <label class="select">
wrapper instead of putting the class directly on <select>. This fixes
selects rendering incorrectly on LiveView navigation (content pressed
against top) while working correctly after a hard refresh.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@ddon ddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. Reviewed — see dev_docs/pull_requests/2026/3-hex-dep-css-daisy5/CLAUDE_REVIEW.md

@ddon ddon merged commit 1ad62d3 into BeamLabEU:main Apr 2, 2026
ddon pushed a commit that referenced this pull request Apr 29, 2026
Both PRs (hex dep + CSS sources + daisyUI 5 selects; routing anti-pattern
AGENTS.md pointer) landed clean reviews with no actionable findings.
Stubs confirm re-verification on 2026-04-25 against current code, per
the Phase 1 playbook convention at agents.md:236.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants