fix(tabs): linkedTo props added and Tabs type updated #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ntorionbearstudio
requested changes
Feb 3, 2025
| import { getThemeColor } from '../../theme/theme.service'; | ||
|
|
||
| const Tab: FC<TabProps> = ({ name, children, ...rest }) => { | ||
| const Tab: FC<TabProps> = ({ children, ...rest }) => { |
Contributor
There was a problem hiding this comment.
unused but name is defined here to not be inside rest prop
| export interface TabsProps<T extends Route = Route> | ||
| extends CommonStyleProps, | ||
| RNTabViewProps<T> { | ||
| export interface TabsProps extends CommonStyleProps { |
Contributor
There was a problem hiding this comment.
we need to keep RNTabViewProps to be able to pass all existing props of react-native-tab-view to our component
| } | ||
|
|
||
| export interface TabPanelProps extends CommonStyleProps { | ||
| linkedTo: string; |
Contributor
|
Will be fixed in V2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unused name props in tabs.component.tsx deleted
unused type deleted as the RNTabViewProps are used within the View that is returned in the tabs component. :