fix(i18n): replace hardcoded validation and empty-state strings#141
Merged
HugoPerard merged 1 commit intoBearStudio:mainfrom Apr 28, 2026
Merged
Conversation
Wraps three previously hardcoded English strings in i18n keys so they
translate to French (and any future locale): the books empty-state
("There is no books" — also fixes the grammar to "There are no books"),
the auth onboarding name validator, and the account update-name
validator. Adds matching keys to en/fr namespaces.
yoannfleurydev
approved these changes
Apr 27, 2026
ntorionbearstudio
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps three previously hardcoded English strings in i18n keys so they translate to French (and any future locale): the books empty-state ("There is no books" — also fixes the grammar to "There are no books"), the auth onboarding name validator, and the account update-name validator. Adds matching keys to en/fr namespaces.